fix: resets store state on logout, fixes E2E test assertions

Author: wgordon17

e2e/settings.spec.ts

@@ -97,8 +97,7 @@ test("changing theme to dark adds dark class to html element", async ({
   await page.goto("/settings");
 
   // Locate the Theme setting row by its label text, then find its <select> child.
-  const themeRow = page.locator("div").filter({ hasText: /^Theme$/ }).first();
-  const themeSelect = themeRow.locator("select");
+  const themeSelect = page.getByRole("combobox").filter({ has: page.locator('option[value="dark"]') });
   await themeSelect.selectOption("dark");
 
   const htmlElement = page.locator("html");
@@ -125,9 +124,15 @@ test("sign out clears auth and redirects to login", async ({ page }) => {
   // clearAuth() clears in-memory token and navigates to /login
   await expect(page).toHaveURL(/\/login/);
 
-  // Verify config was cleared from localStorage (SDR-016 data leakage prevention)
+  // Verify config was reset (SDR-016 data leakage prevention).
+  // The persistence effect may re-write defaults, so check that user-specific
+  // data (selectedOrgs, onboardingComplete) was cleared rather than checking null.
   const configEntry = await page.evaluate(() =>
     localStorage.getItem("github-tracker:config")
   );
-  expect(configEntry).toBeNull();
+  if (configEntry !== null) {
+    const parsed = JSON.parse(configEntry);
+    expect(parsed.selectedOrgs).toEqual([]);
+    expect(parsed.onboardingComplete).toBe(false);
+  }
 });

e2e/smoke.spec.ts

@@ -123,8 +123,9 @@ test("OAuth callback flow completes and redirects", async ({ page }) => {
 
   await page.goto(`/oauth/callback?code=fakecode&state=${fakeState}`);
 
-  // After successful auth the callback navigates to '/' then to /dashboard
-  await expect(page).toHaveURL(/\/dashboard/);
+  // After successful auth the callback navigates to '/' which redirects
+  // to /dashboard (if onboardingComplete) or /onboarding (first login)
+  await expect(page).toHaveURL(/\/(dashboard|onboarding)/);
 });
 
 // ── Dashboard ────────────────────────────────────────────────────────────────
@@ -136,20 +137,20 @@ test("dashboard loads with tab bar visible", async ({ page }) => {
   const nav = page.getByRole("navigation", { name: /dashboard tabs/i });
   await expect(nav).toBeVisible();
 
-  await expect(page.getByRole("button", { name: /^issues$/i })).toBeVisible();
+  await expect(page.getByRole("button", { name: /^issues/i })).toBeVisible();
   await expect(
-    page.getByRole("button", { name: /^pull requests$/i })
+    page.getByRole("button", { name: /^pull requests/i })
   ).toBeVisible();
-  await expect(page.getByRole("button", { name: /^actions$/i })).toBeVisible();
+  await expect(page.getByRole("button", { name: /^actions/i })).toBeVisible();
 });
 
 test("switching tabs changes active tab indicator", async ({ page }) => {
   await setupAuth(page);
   await page.goto("/dashboard");
 
-  const issuesBtn = page.getByRole("button", { name: /^issues$/i });
-  const prBtn = page.getByRole("button", { name: /^pull requests$/i });
-  const actionsBtn = page.getByRole("button", { name: /^actions$/i });
+  const issuesBtn = page.getByRole("button", { name: /^issues/i });
+  const prBtn = page.getByRole("button", { name: /^pull requests/i });
+  const actionsBtn = page.getByRole("button", { name: /^actions/i });
 
   // Default tab should be issues (or whatever config says; we didn't set defaultTab)
   await expect(issuesBtn).toBeVisible();

src/app/stores/auth.ts

@@ -1,7 +1,7 @@
 import { createSignal } from "solid-js";
 import { clearCache } from "./cache";
-import { CONFIG_STORAGE_KEY } from "./config";
-import { VIEW_STORAGE_KEY } from "./view";
+import { CONFIG_STORAGE_KEY, resetConfig } from "./config";
+import { VIEW_STORAGE_KEY, resetViewState } from "./view";
 
 export interface GitHubUser {
   login: string;
@@ -47,7 +47,11 @@ export function onAuthCleared(cb: () => void): void {
 }
 
 export function clearAuth(): void {
-  // Clear config and view state to prevent data leakage between users (SDR-016)
+  // Reset in-memory stores to defaults BEFORE clearing localStorage,
+  // so the persistence effects re-write defaults (not stale user data).
+  resetConfig();
+  resetViewState();
+  // Clear localStorage entries (persistence effects will write back defaults)
   localStorage.removeItem(CONFIG_STORAGE_KEY);
   localStorage.removeItem(VIEW_STORAGE_KEY);
   _setToken(null);

src/app/stores/config.ts

@@ -59,6 +59,11 @@ export function updateConfig(partial: Partial<Config>): void {
   );
 }
 
+export function resetConfig(): void {
+  const defaults = ConfigSchema.parse({});
+  setConfig(defaults);
+}
+
 export function initConfigPersistence(): void {
   let debounceTimer: ReturnType<typeof setTimeout> | undefined;
   createEffect(() => {

src/app/stores/view.ts

@@ -92,6 +92,11 @@ export const [viewState, setViewState] = createStore<ViewState>(
   loadViewState()
 );
 
+export function resetViewState(): void {
+  const defaults = ViewStateSchema.parse({});
+  setViewState(defaults);
+}
+
 export function updateViewState(partial: Partial<ViewState>): void {
   setViewState(
     produce((draft) => {