fix(poll): uses serialized keys for notification reset

Author: wgordon17

src/app/services/poll.ts

@@ -87,35 +87,35 @@ export function resetPollState(): void {
 // Auto-reset poll state on logout (avoids circular dep with auth.ts)
 onAuthCleared(resetPollState);
 
-// When tracked users change, reset notification state so the next poll cycle
-// silently seeds all items (including the new tracked user's) without flooding
-// the user with "new item" notifications for pre-existing content.
-// Use a flag to skip the initial run (module-level mount).
-// Wrapped in createRoot to provide a reactive owner at module scope (per SolidJS gotcha).
-// Subscribes to array length only — fires on add/remove, not property mutations.
-let _trackedUsersMounted = false;
+// When tracked users or monitored repos change, reset notification state so the
+// next poll cycle silently seeds items without flooding "new item" notifications.
+// Tracks a serialized key (sorted logins/fullNames) so swapping entries at the
+// same array length still triggers the reset.
+let _trackedUsersKey = "";
+let _monitoredReposKey = "";
 createRoot(() => {
   createEffect(() => {
-    void (config.trackedUsers?.length ?? 0);
-    if (!_trackedUsersMounted) {
-      _trackedUsersMounted = true;
+    const key = (config.trackedUsers ?? []).map((u) => u.login).sort().join(",");
+    if (_trackedUsersKey === "") {
+      _trackedUsersKey = key;
       return;
     }
-    untrack(() => _resetNotificationState());
+    if (key !== _trackedUsersKey) {
+      _trackedUsersKey = key;
+      untrack(() => _resetNotificationState());
+    }
   });
-});
 
-// When monitoredRepos changes, reset notification state so the next poll cycle
-// silently seeds the newly monitored repo's items without flooding with notifications.
-let _monitoredReposMounted = false;
-createRoot(() => {
   createEffect(() => {
-    void (config.monitoredRepos?.length ?? 0);
-    if (!_monitoredReposMounted) {
-      _monitoredReposMounted = true;
+    const key = (config.monitoredRepos ?? []).map((r) => r.fullName).sort().join(",");
+    if (_monitoredReposKey === "") {
+      _monitoredReposKey = key;
       return;
     }
-    untrack(() => _resetNotificationState());
+    if (key !== _monitoredReposKey) {
+      _monitoredReposKey = key;
+      untrack(() => _resetNotificationState());
+    }
   });
 });
 

tests/services/api.test.ts

@@ -1615,6 +1615,68 @@ describe("fetchIssuesAndPullRequests — monitoredRepos", () => {
   });
 });
 
+describe("fetchIssuesAndPullRequests — all repos monitored (edge case)", () => {
+  it("skips main user light search and returns items from unfiltered search only", async () => {
+    const queriesUsed: string[] = [];
+    const repo = { owner: "org", name: "repo1", fullName: "org/repo1" };
+
+    const issueNode = {
+      databaseId: 3001,
+      number: 1,
+      title: "All-monitored issue",
+      state: "open",
+      url: "https://github.com/org/repo1/issues/1",
+      createdAt: "2024-01-01T00:00:00Z",
+      updatedAt: "2024-01-02T00:00:00Z",
+      author: { login: "someone", avatarUrl: "https://avatars.githubusercontent.com/u/1" },
+      labels: { nodes: [] },
+      assignees: { nodes: [] },
+      repository: { nameWithOwner: "org/repo1" },
+      comments: { totalCount: 0 },
+    };
+
+    const octokit = makeOctokit(
+      async () => ({ data: {}, headers: {} }),
+      async (_query: string, variables: unknown) => {
+        const vars = variables as Record<string, unknown>;
+        if (vars.issueQ) queriesUsed.push(vars.issueQ as string);
+        return {
+          issues: { issueCount: 1, pageInfo: { hasNextPage: false, endCursor: null }, nodes: [issueNode] },
+          prs: { issueCount: 0, pageInfo: { hasNextPage: false, endCursor: null }, nodes: [] },
+          prInvolves: { issueCount: 0, pageInfo: { hasNextPage: false, endCursor: null }, nodes: [] },
+          prReviewReq: { issueCount: 0, pageInfo: { hasNextPage: false, endCursor: null }, nodes: [] },
+          rateLimit: { limit: 5000, remaining: 4999, resetAt: new Date(Date.now() + 3600000).toISOString() },
+        };
+      }
+    );
+
+    const { fetchIssuesAndPullRequests } = await import("../../src/app/services/api");
+    const result = await fetchIssuesAndPullRequests(
+      octokit as never,
+      [repo],
+      "octocat",
+      undefined,
+      undefined,
+      [{ fullName: "org/repo1" }]  // all repos monitored
+    );
+
+    // Items returned from unfiltered search
+    expect(result.issues).toHaveLength(1);
+    expect(result.issues[0].id).toBe(3001);
+
+    // No involves: query (main user search skipped since normalRepos is empty)
+    const involvesQueries = queriesUsed.filter(q => q.includes("involves:octocat"));
+    expect(involvesQueries).toHaveLength(0);
+
+    // Unfiltered query was issued (no involves: qualifier)
+    const unfilteredQueries = queriesUsed.filter(q => !q.includes("involves:") && !q.includes("review-requested:"));
+    expect(unfilteredQueries.length).toBeGreaterThan(0);
+
+    // Item has no surfacedBy (unfiltered search items aren't attributed to a user)
+    expect(result.issues[0].surfacedBy).toBeUndefined();
+  });
+});
+
 // ── fetchIssuesAndPullRequests — cross-feature integration (monitored + bot) ──
 
 describe("fetchIssuesAndPullRequests — cross-feature: monitored repo + bot tracked user", () => {