feat: adds bot user tracking and per-repo monitor-all mode (#38)

* feat: adds bot user tracking and per-repo monitor-all mode

* fix(poll): uses serialized keys for notification reset

* fix(poll): restores boolean mount guard for notification reset

* fix(api): addresses PR #38 review findings

- removes trackedSearchRepos fallback that sent involves: queries to
  monitored repos when all repos were monitored
- extracts SEARCH_RESULT_CAP module-level constant (replaces 4 local
  declarations)
- extracts LIGHT_ISSUE_FRAGMENT GraphQL fragment (eliminates 3rd copy
  of inline issue field selection)
- simplifies SettingsPage onMonitorToggle lambda
- types monitoredRepos prop as RepoRef[] in tab components
- documents poll.ts mount-guard permanence across resetPollState()
- adds 6 tests: unfiltered search error handling, all-monitored +
  tracked users, onLightData suppression, upstream repo toggle guard

* fix(api): addresses Layer 1.5 domain review findings

- types fetchIssuesAndPullRequests monitoredRepos param as RepoRef[]
- uses SEARCH_RESULT_CAP in pushNotification strings (removes hardcoded 1,000)
- removes stale section comment header
- tightens test assertion for retryable error
- updates test callsites to use full RepoRef objects

* fix(api): pins toLocaleString locale to en-US in notification strings

* fix: addresses remaining deferred findings (qa-5, perf-2)

- adds poll notification reset reactive effect tests (qa-5): verifies
  _resetNotificationState fires on monitoredRepos and trackedUsers
  config changes, skips on initial mount, detects key swaps
- adds .max(10) constraint on monitoredRepos schema (perf-2): limits
  unfiltered search volume, adds guard in setMonitoredRepo
- adds schema constraint tests for monitoredRepos max

* fix(auth): adds localStorage resilience and 401 retry

* fix: addresses PR review findings from code review

* fix: monitor-all gate bypass, hot poll guard, and UX

- invalidates notifications gate when monitoredRepos or trackedUsers
  change so next poll fetches fresh data instead of returning stale 304
- tightens hot poll PR qualifier to require enriched === true, excluding
  unenriched and null-checkStatus PRs from unnecessary polling
- switches monitor-all eyeball icon from opacity toggle to text-info
  color for better enabled/disabled contrast
- adds "Monitoring all" indicator with repo names on Settings page
- adds regex constraints to RepoRefSchema for defense-in-depth validation
- sets makePullRequest helper default to enriched: true (steady state)
- adds gate bypass integration tests and Settings indicator render tests

Author: wgordon17

src/app/components/dashboard/DashboardPage.tsx

@@ -19,7 +19,8 @@ import {
   fetchAllData,
   type DashboardData,
 } from "../../services/poll";
-import { clearAuth, user, onAuthCleared, DASHBOARD_STORAGE_KEY } from "../../stores/auth";
+import { expireToken, user, onAuthCleared, DASHBOARD_STORAGE_KEY } from "../../stores/auth";
+import { pushNotification } from "../../lib/errors";
 import { getClient, getGraphqlRateLimit } from "../../services/github";
 import { formatCount } from "../../lib/format";
 import { setsEqual } from "../../lib/collections";
@@ -191,7 +192,7 @@ async function pollFetch(): Promise<DashboardData> {
         try {
           localStorage.setItem(DASHBOARD_STORAGE_KEY, JSON.stringify(cachePayload));
         } catch {
-          // localStorage full or unavailable — non-fatal
+          pushNotification("localStorage:dashboard", "Dashboard cache write failed — storage may be full", "warning");
         }
       }, 0);
     } else {
@@ -208,9 +209,9 @@ async function pollFetch(): Promise<DashboardData> {
         : null;
 
     if (status === 401) {
-      // Hard redirect (not navigate()) forces a full page reload, which clears
-      // module-level state like _coordinator and dashboardData for the next user.
-      clearAuth();
+      // Token invalid — clear token only, preserve user config/view/dashboard.
+      // Hard redirect forces a full page reload, clearing module-level state.
+      expireToken();
       window.location.replace("/login");
     }
     setDashboardData("loading", false);
@@ -359,6 +360,7 @@ export default function DashboardPage() {
                   userLogin={userLogin()}
                   allUsers={allUsers()}
                   trackedUsers={config.trackedUsers}
+                  monitoredRepos={config.monitoredRepos}
                 />
               </Match>
               <Match when={activeTab() === "pullRequests"}>
@@ -369,6 +371,7 @@ export default function DashboardPage() {
                   allUsers={allUsers()}
                   trackedUsers={config.trackedUsers}
                   hotPollingPRIds={hotPollingPRIds()}
+                  monitoredRepos={config.monitoredRepos}
                 />
               </Match>
               <Match when={activeTab() === "actions"}>

src/app/components/dashboard/IssuesTab.tsx

@@ -1,7 +1,7 @@
 import { createEffect, createMemo, createSignal, For, Show } from "solid-js";
 import { config, type TrackedUser } from "../../stores/config";
 import { viewState, setSortPreference, setTabFilter, resetTabFilter, resetAllTabFilters, ignoreItem, unignoreItem, toggleExpandedRepo, setAllExpanded, pruneExpandedRepos, pruneLockedRepos, type IssueFilterField } from "../../stores/view";
-import type { Issue } from "../../services/api";
+import type { Issue, RepoRef } from "../../services/api";
 import ItemRow from "./ItemRow";
 import UserAvatarBadge, { buildSurfacedByUsers } from "../shared/UserAvatarBadge";
 import IgnoreBadge from "./IgnoreBadge";
@@ -25,6 +25,7 @@ export interface IssuesTabProps {
   userLogin: string;
   allUsers?: { login: string; label: string }[];
   trackedUsers?: TrackedUser[];
+  monitoredRepos?: RepoRef[];
 }
 
 type SortField = "repo" | "title" | "author" | "createdAt" | "updatedAt" | "comments";
@@ -68,6 +69,10 @@ export default function IssuesTab(props: IssuesTabProps) {
     new Set((config.upstreamRepos ?? []).map(r => r.fullName))
   );
 
+  const monitoredRepoNameSet = createMemo(() =>
+    new Set((props.monitoredRepos ?? []).map(r => r.fullName))
+  );
+
   const filterGroups = createMemo<FilterChipGroupDef[]>(() => {
     const users = props.allUsers;
     if (!users || users.length <= 1) return issueFilterGroups;
@@ -114,10 +119,13 @@ export default function IssuesTab(props: IssuesTabProps) {
       }
 
       if (tabFilter.user !== "all") {
-        const validUser = !props.allUsers || props.allUsers.some(u => u.login === tabFilter.user);
-        if (validUser) {
-          const surfacedBy = issue.surfacedBy ?? [props.userLogin.toLowerCase()];
-          if (!surfacedBy.includes(tabFilter.user)) return false;
+        // Items from monitored repos bypass the surfacedBy filter (all activity is shown)
+        if (!monitoredRepoNameSet().has(issue.repoFullName)) {
+          const validUser = !props.allUsers || props.allUsers.some(u => u.login === tabFilter.user);
+          if (validUser) {
+            const surfacedBy = issue.surfacedBy ?? [props.userLogin.toLowerCase()];
+            if (!surfacedBy.includes(tabFilter.user)) return false;
+          }
         }
       }
 
@@ -305,6 +313,9 @@ export default function IssuesTab(props: IssuesTabProps) {
                       >
                         <ChevronIcon size="md" rotated={!isExpanded()} />
                         {repoGroup.repoFullName}
+                        <Show when={monitoredRepoNameSet().has(repoGroup.repoFullName)}>
+                          <span class="badge badge-xs badge-ghost" aria-label="monitoring all activity">Monitoring all</span>
+                        </Show>
                         <Show when={!isExpanded()}>
                           <span class="ml-auto flex items-center gap-2 text-xs font-normal text-base-content/60">
                             <span>{repoGroup.items.length} {repoGroup.items.length === 1 ? "issue" : "issues"}</span>

src/app/components/dashboard/PullRequestsTab.tsx

@@ -1,7 +1,7 @@
 import { createEffect, createMemo, createSignal, For, Show } from "solid-js";
 import { config, type TrackedUser } from "../../stores/config";
 import { viewState, setSortPreference, ignoreItem, unignoreItem, setTabFilter, resetTabFilter, resetAllTabFilters, toggleExpandedRepo, setAllExpanded, pruneExpandedRepos, pruneLockedRepos, type PullRequestFilterField } from "../../stores/view";
-import type { PullRequest } from "../../services/api";
+import type { PullRequest, RepoRef } from "../../services/api";
 import { deriveInvolvementRoles, prSizeCategory } from "../../lib/format";
 import ExpandCollapseButtons from "../shared/ExpandCollapseButtons";
 import ItemRow from "./ItemRow";
@@ -30,6 +30,7 @@ export interface PullRequestsTabProps {
   allUsers?: { login: string; label: string }[];
   trackedUsers?: TrackedUser[];
   hotPollingPRIds?: ReadonlySet<number>;
+  monitoredRepos?: RepoRef[];
 }
 
 type SortField = "repo" | "title" | "author" | "createdAt" | "updatedAt" | "checkStatus" | "reviewDecision" | "size";
@@ -135,6 +136,10 @@ export default function PullRequestsTab(props: PullRequestsTabProps) {
     new Set((config.upstreamRepos ?? []).map(r => r.fullName))
   );
 
+  const monitoredRepoNameSet = createMemo(() =>
+    new Set((props.monitoredRepos ?? []).map(r => r.fullName))
+  );
+
   const filterGroups = createMemo<FilterChipGroupDef[]>(() => {
     const users = props.allUsers;
     if (!users || users.length <= 1) return prFilterGroups;
@@ -199,10 +204,13 @@ export default function PullRequestsTab(props: PullRequestsTabProps) {
       }
 
       if (tabFilters.user !== "all") {
-        const validUser = !props.allUsers || props.allUsers.some(u => u.login === tabFilters.user);
-        if (validUser) {
-          const surfacedBy = pr.surfacedBy ?? [props.userLogin.toLowerCase()];
-          if (!surfacedBy.includes(tabFilters.user)) return false;
+        // Items from monitored repos bypass the surfacedBy filter (all activity is shown)
+        if (!monitoredRepoNameSet().has(pr.repoFullName)) {
+          const validUser = !props.allUsers || props.allUsers.some(u => u.login === tabFilters.user);
+          if (validUser) {
+            const surfacedBy = pr.surfacedBy ?? [props.userLogin.toLowerCase()];
+            if (!surfacedBy.includes(tabFilters.user)) return false;
+          }
         }
       }
 
@@ -418,6 +426,9 @@ export default function PullRequestsTab(props: PullRequestsTabProps) {
                       >
                         <ChevronIcon size="md" rotated={!isExpanded()} />
                         {repoGroup.repoFullName}
+                        <Show when={monitoredRepoNameSet().has(repoGroup.repoFullName)}>
+                          <span class="badge badge-xs badge-ghost" aria-label="monitoring all activity">Monitoring all</span>
+                        </Show>
                         <Show when={!isExpanded()}>
                           <span class="ml-auto flex items-center gap-2 text-xs font-normal text-base-content/60 shrink-0">
                             <span>{repoGroup.items.length} {repoGroup.items.length === 1 ? "PR" : "PRs"}</span>

src/app/components/onboarding/OnboardingWizard.tsx

@@ -7,6 +7,7 @@ import {
   Match,
 } from "solid-js";
 import { config, updateConfig, CONFIG_STORAGE_KEY } from "../../stores/config";
+import { pushNotification } from "../../lib/errors";
 import { fetchOrgs, type OrgEntry, type RepoRef } from "../../services/api";
 import { getClient } from "../../services/github";
 import RepoSelector from "./RepoSelector";
@@ -19,6 +20,9 @@ export default function OnboardingWizard() {
   const [upstreamRepos, setUpstreamRepos] = createSignal<RepoRef[]>(
     config.upstreamRepos.length > 0 ? [...config.upstreamRepos] : []
   );
+  const [monitoredRepos, setMonitoredRepos] = createSignal<RepoRef[]>(
+    config.monitoredRepos.length > 0 ? [...config.monitoredRepos] : []
+  );
 
   const [loading, setLoading] = createSignal(true);
   const [error, setError] = createSignal<string | null>(null);
@@ -57,10 +61,15 @@ export default function OnboardingWizard() {
       selectedOrgs: uniqueOrgs,
       selectedRepos: selectedRepos(),
       upstreamRepos: upstreamRepos(),
+      monitoredRepos: monitoredRepos(),
       onboardingComplete: true,
     });
     // Flush synchronously — the debounced persistence effect won't fire before page unload
-    localStorage.setItem(CONFIG_STORAGE_KEY, JSON.stringify(config));
+    try {
+      localStorage.setItem(CONFIG_STORAGE_KEY, JSON.stringify(config));
+    } catch {
+      pushNotification("localStorage:config", "Config write failed — storage may be full", "warning");
+    }
     window.location.replace("/dashboard");
   }
 
@@ -116,6 +125,14 @@ export default function OnboardingWizard() {
                   upstreamRepos={upstreamRepos()}
                   onUpstreamChange={setUpstreamRepos}
                   trackedUsers={config.trackedUsers}
+                  monitoredRepos={monitoredRepos()}
+                  onMonitorToggle={(repo, monitored) => {
+                    if (monitored) {
+                      setMonitoredRepos((prev) => prev.some((r) => r.fullName === repo.fullName) ? prev : [...prev, repo]);
+                    } else {
+                      setMonitoredRepos((prev) => prev.filter((r) => r.fullName !== repo.fullName));
+                    }
+                  }}
                 />
               </Match>
             </Switch>

src/app/components/onboarding/RepoSelector.tsx

@@ -10,6 +10,7 @@ import {
 import { fetchOrgs, fetchRepos, discoverUpstreamRepos, OrgEntry, RepoRef, RepoEntry } from "../../services/api";
 import { getClient } from "../../services/github";
 import { user } from "../../stores/auth";
+import type { TrackedUser } from "../../stores/config";
 import { relativeTime } from "../../lib/format";
 import LoadingSpinner from "../shared/LoadingSpinner";
 import FilterInput from "../shared/FilterInput";
@@ -25,7 +26,9 @@ interface RepoSelectorProps {
   showUpstreamDiscovery?: boolean;
   upstreamRepos?: RepoRef[];
   onUpstreamChange?: (repos: RepoRef[]) => void;
-  trackedUsers?: { login: string; avatarUrl: string; name: string | null }[];
+  trackedUsers?: TrackedUser[];
+  monitoredRepos?: RepoRef[];
+  onMonitorToggle?: (repo: RepoRef, monitored: boolean) => void;
 }
 
 interface OrgRepoState {
@@ -225,6 +228,10 @@ export default function RepoSelector(props: RepoSelectorProps) {
     new Set(props.selected.map((r) => r.fullName))
   );
 
+  const monitoredSet = createMemo(() =>
+    new Set((props.monitoredRepos ?? []).map((r) => r.fullName))
+  );
+
   const sortedOrgStates = createMemo(() => {
     const states = orgStates();
     // Defer sorting until all orgs have loaded: prevents layout shift during
@@ -527,26 +534,51 @@ export default function RepoSelector(props: RepoSelectorProps) {
                         {(repo) => {
                           return (
                             <li>
-                              <label class="flex cursor-pointer items-start gap-3 px-4 py-3 hover:bg-base-200">
-                                <input
-                                  type="checkbox"
-                                  checked={isSelected(repo().fullName)}
-                                  onChange={() => toggleRepo(repo())}
-                                  class="checkbox checkbox-primary checkbox-sm mt-0.5"
-                                />
-                                <div class="min-w-0 flex-1">
-                                  <div class="flex items-center gap-2">
-                                    <span class="min-w-0 truncate text-sm font-medium text-base-content">
-                                      {repo().name}
-                                    </span>
-                                    <Show when={repo().pushedAt}>
-                                      <span class="ml-auto shrink-0 text-xs text-base-content/60">
-                                        {relativeTime(repo().pushedAt!)}
+                              <div class="flex items-center">
+                                <label class="flex cursor-pointer items-start gap-3 px-4 py-3 hover:bg-base-200 flex-1">
+                                  <input
+                                    type="checkbox"
+                                    checked={isSelected(repo().fullName)}
+                                    onChange={() => toggleRepo(repo())}
+                                    class="checkbox checkbox-primary checkbox-sm mt-0.5"
+                                  />
+                                  <div class="min-w-0 flex-1">
+                                    <div class="flex items-center gap-2">
+                                      <span class="min-w-0 truncate text-sm font-medium text-base-content">
+                                        {repo().name}
                                       </span>
-                                    </Show>
+                                      <Show when={repo().pushedAt}>
+                                        <span class="ml-auto shrink-0 text-xs text-base-content/60">
+                                          {relativeTime(repo().pushedAt!)}
+                                        </span>
+                                      </Show>
+                                    </div>
                                   </div>
-                                </div>
-                              </label>
+                                </label>
+                                <Show when={isSelected(repo().fullName) && props.onMonitorToggle && !upstreamSelectedSet().has(repo().fullName)}>
+                                  <button
+                                    type="button"
+                                    onClick={(e) => {
+                                      e.stopPropagation();
+                                      props.onMonitorToggle?.(toRepoRef(repo()), !monitoredSet().has(repo().fullName));
+                                    }}
+                                    class="btn btn-ghost btn-sm btn-circle mr-2"
+                                    classList={{
+                                      "text-info": monitoredSet().has(repo().fullName),
+                                      "text-base-content/20": !monitoredSet().has(repo().fullName),
+                                    }}
+                                    title={monitoredSet().has(repo().fullName) ? "Stop monitoring all activity" : "Monitor all activity"}
+                                    aria-label={monitoredSet().has(repo().fullName) ? "Stop monitoring all activity" : "Monitor all activity"}
+                                    aria-pressed={monitoredSet().has(repo().fullName)}
+                                  >
+                                    {/* Heroicons eye outline 16px */}
+                                    <svg xmlns="http://www.w3.org/2000/svg" class="h-4 w-4" fill="none" viewBox="0 0 24 24" stroke="currentColor" stroke-width={2} aria-hidden="true">
+                                      <path stroke-linecap="round" stroke-linejoin="round" d="M15 12a3 3 0 11-6 0 3 3 0 016 0z" />
+                                      <path stroke-linecap="round" stroke-linejoin="round" d="M2.458 12C3.732 7.943 7.523 5 12 5c4.478 0 8.268 2.943 9.542 7-1.274 4.057-5.064 7-9.542 7-4.477 0-8.268-2.943-9.542-7z" />
+                                    </svg>
+                                  </button>
+                                </Show>
+                              </div>
                             </li>
                           );
                         }}

src/app/components/settings/SettingsPage.tsx

@@ -1,6 +1,6 @@
-import { createSignal, Show, onCleanup } from "solid-js";
+import { createSignal, createMemo, Show, onCleanup } from "solid-js";
 import { useNavigate } from "@solidjs/router";
-import { config, updateConfig } from "../../stores/config";
+import { config, updateConfig, setMonitoredRepo } from "../../stores/config";
 import { clearAuth } from "../../stores/auth";
 import { clearCache } from "../../stores/cache";
 import { pushNotification } from "../../lib/errors";
@@ -54,6 +54,10 @@ export default function SettingsPage() {
   const [localRepos, setLocalRepos] = createSignal<RepoRef[]>(config.selectedRepos);
   const [localUpstream, setLocalUpstream] = createSignal<RepoRef[]>(config.upstreamRepos);
 
+  const monitoredRepoNames = createMemo(() =>
+    config.monitoredRepos.map(r => r.fullName).join(", ")
+  );
+
   // ── Helpers ──────────────────────────────────────────────────────────────
 
   async function mergeNewOrgs() {
@@ -142,6 +146,7 @@ export default function SettingsPage() {
         selectedOrgs: config.selectedOrgs,
         selectedRepos: config.selectedRepos,
         upstreamRepos: config.upstreamRepos,
+        monitoredRepos: config.monitoredRepos,
         trackedUsers: config.trackedUsers,
         refreshInterval: config.refreshInterval,
         hotPollInterval: config.hotPollInterval,
@@ -304,6 +309,15 @@ export default function SettingsPage() {
                       Tracking {localRepos().length} repos will use significant API quota per poll cycle
                     </p>
                   </Show>
+                  <Show when={config.monitoredRepos.length > 0}>
+                    <p class="text-xs text-info flex items-center gap-1 mt-0.5">
+                      <svg xmlns="http://www.w3.org/2000/svg" class="h-3 w-3 shrink-0" fill="none" viewBox="0 0 24 24" stroke="currentColor" stroke-width={2} aria-hidden="true">
+                        <path stroke-linecap="round" stroke-linejoin="round" d="M15 12a3 3 0 11-6 0 3 3 0 016 0z" />
+                        <path stroke-linecap="round" stroke-linejoin="round" d="M2.458 12C3.732 7.943 7.523 5 12 5c4.478 0 8.268 2.943 9.542 7-1.274 4.057-5.064 7-9.542 7-4.477 0-8.268-2.943-9.542-7z" />
+                      </svg>
+                      Monitoring all: {monitoredRepoNames()}
+                    </p>
+                  </Show>
                 </div>
                 <button
                   type="button"
@@ -324,6 +338,8 @@ export default function SettingsPage() {
                   upstreamRepos={localUpstream()}
                   onUpstreamChange={handleUpstreamChange}
                   trackedUsers={config.trackedUsers}
+                  monitoredRepos={config.monitoredRepos}
+                  onMonitorToggle={setMonitoredRepo}
                 />
               </div>
             </Show>