refactor: extracts isUserInvolved, documents approximations

Author: wgordon17

src/app/components/dashboard/IssuesTab.tsx

@@ -14,7 +14,7 @@ import SkeletonRows from "../shared/SkeletonRows";
 import ChevronIcon from "../shared/ChevronIcon";
 import ExpandCollapseButtons from "../shared/ExpandCollapseButtons";
 import { deriveInvolvementRoles, formatStarCount } from "../../lib/format";
-import { groupByRepo, computePageLayout, slicePageGroups, orderRepoGroups } from "../../lib/grouping";
+import { groupByRepo, computePageLayout, slicePageGroups, orderRepoGroups, isUserInvolved } from "../../lib/grouping";
 import { createReorderHighlight } from "../../lib/reorderHighlight";
 import RepoLockControls from "../shared/RepoLockControls";
 import RepoGitHubLink from "../shared/RepoGitHubLink";
@@ -103,16 +103,8 @@ export default function IssuesTab(props: IssuesTabProps) {
     }
   });
 
-  function isInvolvedItem(item: Issue): boolean {
-    const login = userLoginLower();
-    const surfacedBy = item.surfacedBy ?? [];
-    if (surfacedBy.length > 0) return surfacedBy.includes(login);
-    if (monitoredRepoNameSet().has(item.repoFullName)) {
-      return item.userLogin.toLowerCase() === login ||
-        item.assigneeLogins.some((a) => a.toLowerCase() === login);
-    }
-    return true;
-  }
+  const isInvolvedItem = (item: Issue) =>
+    isUserInvolved(item, userLoginLower(), monitoredRepoNameSet());
 
   const sortPref = createMemo(() => {
     const pref = viewState.sortPreferences["issues"];

src/app/components/dashboard/PersonalSummaryStrip.tsx

@@ -87,8 +87,18 @@ export default function PersonalSummaryStrip(props: PersonalSummaryStripProps) {
     const { prsAwaitingReview, prsReadyToMerge, prsBlocked } = prCounts();
     const running = runningActions();
     const items: SummaryCount[] = [];
-    // Summary counts from unfiltered data — set scope=all so the filtered view
-    // matches. The specific filters (role, checkStatus) already ensure relevance.
+    // ── Count-to-filter contract ──
+    // Counts are computed from unfiltered data (ignoring scope, globalFilter, showPrRuns).
+    // Click filters set scope=all so tabs don't hide items the count included.
+    // Known approximations (single-value filter system cannot express these):
+    //   - "ready to merge": count requires reviewDecision=APPROVED||null, but filter
+    //     can't express OR — PRs with CHANGES_REQUESTED + passing CI may appear
+    //   - "awaiting review": count excludes self-authored PRs (!isAuthor), but
+    //     role=reviewer filter includes them if user is both author+reviewer (rare)
+    //   - globalFilter (org/repo) is NOT applied here — counts are persistent
+    //     awareness across all repos, matching the tab badge behavior
+    //   - "running": count includes all in_progress runs; click enables showPrRuns
+    //     so PR-triggered runs are visible in the tab
     if (assignedIssues > 0) items.push({
       label: assignedIssues === 1 ? "issue assigned" : "issues assigned",
       count: assignedIssues,

src/app/components/dashboard/PullRequestsTab.tsx

@@ -18,7 +18,7 @@ import SizeBadge from "../shared/SizeBadge";
 import RoleBadge from "../shared/RoleBadge";
 import SkeletonRows from "../shared/SkeletonRows";
 import ChevronIcon from "../shared/ChevronIcon";
-import { groupByRepo, computePageLayout, slicePageGroups, orderRepoGroups } from "../../lib/grouping";
+import { groupByRepo, computePageLayout, slicePageGroups, orderRepoGroups, isUserInvolved } from "../../lib/grouping";
 import { createReorderHighlight } from "../../lib/reorderHighlight";
 import { createFlashDetection } from "../../lib/flashDetection";
 import RepoLockControls from "../shared/RepoLockControls";
@@ -172,17 +172,9 @@ export default function PullRequestsTab(props: PullRequestsTabProps) {
     }
   });
 
-  function isInvolvedItem(item: PullRequest): boolean {
-    const login = userLoginLower();
-    const surfacedBy = item.surfacedBy ?? [];
-    if (surfacedBy.length > 0) return surfacedBy.includes(login);
-    if (monitoredRepoNameSet().has(item.repoFullName)) {
-      return item.userLogin.toLowerCase() === login ||
-        item.assigneeLogins.some(a => a.toLowerCase() === login) ||
-        (item.enriched !== false && item.reviewerLogins.some(r => r.toLowerCase() === login));
-    }
-    return true;
-  }
+  const isInvolvedItem = (item: PullRequest) =>
+    isUserInvolved(item, userLoginLower(), monitoredRepoNameSet(),
+      item.enriched !== false ? item.reviewerLogins : undefined);
 
   const sortPref = createMemo(() => {
     const pref = viewState.sortPreferences["pullRequests"];

src/app/lib/grouping.ts

@@ -73,6 +73,31 @@ export function orderRepoGroups<G extends { repoFullName: string }>(
   return [...locked, ...unlocked];
 }
 
+/**
+ * Three-tier involvement check for scope filtering.
+ * Shared by IssuesTab and PullRequestsTab — keep both call sites in sync.
+ *
+ * Tier 1: surfacedBy annotation present → check if user is included
+ * Tier 2: monitored repo (no surfacedBy) → field-based fallback (author/assignee)
+ *         Pass reviewerLogins for PRs (only when enriched — unenriched PRs have [])
+ * Tier 3: non-monitored, no surfacedBy → pass (fetched via involves:{user})
+ */
+export function isUserInvolved(
+  item: { repoFullName: string; userLogin: string; assigneeLogins: string[]; surfacedBy?: string[] },
+  login: string,
+  monitoredRepos: ReadonlySet<string>,
+  reviewerLogins?: string[],
+): boolean {
+  const surfacedBy = item.surfacedBy ?? [];
+  if (surfacedBy.length > 0) return surfacedBy.includes(login);
+  if (monitoredRepos.has(item.repoFullName)) {
+    return item.userLogin.toLowerCase() === login ||
+      item.assigneeLogins.some(a => a.toLowerCase() === login) ||
+      (reviewerLogins != null && reviewerLogins.some(r => r.toLowerCase() === login));
+  }
+  return true;
+}
+
 export function detectReorderedRepos(
   previousOrder: string[],
   currentOrder: string[]

tests/lib/grouping.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect } from "vitest";
-import { groupByRepo, computePageLayout, slicePageGroups, type RepoGroup } from "../../src/app/lib/grouping";
+import { groupByRepo, computePageLayout, slicePageGroups, isUserInvolved, type RepoGroup } from "../../src/app/lib/grouping";
 
 interface Item {
   repoFullName: string;
@@ -59,6 +59,43 @@ describe("groupByRepo", () => {
   });
 });
 
+describe("isUserInvolved", () => {
+  const base = { repoFullName: "org/repo", userLogin: "author", assigneeLogins: [] as string[] };
+  const monitored = new Set(["org/monitored"]);
+
+  it("returns true when surfacedBy includes user", () => {
+    expect(isUserInvolved({ ...base, surfacedBy: ["me"] }, "me", monitored)).toBe(true);
+  });
+
+  it("returns false when surfacedBy excludes user", () => {
+    expect(isUserInvolved({ ...base, surfacedBy: ["other"] }, "me", monitored)).toBe(false);
+  });
+
+  it("returns true for non-monitored item with no surfacedBy (fetched via involves:{user})", () => {
+    expect(isUserInvolved(base, "me", monitored)).toBe(true);
+  });
+
+  it("returns true for monitored repo item when user is author", () => {
+    expect(isUserInvolved({ ...base, repoFullName: "org/monitored", userLogin: "me" }, "me", monitored)).toBe(true);
+  });
+
+  it("returns true for monitored repo item when user is assignee", () => {
+    expect(isUserInvolved({ ...base, repoFullName: "org/monitored", assigneeLogins: ["me"] }, "me", monitored)).toBe(true);
+  });
+
+  it("returns false for monitored repo item when user is not author/assignee", () => {
+    expect(isUserInvolved({ ...base, repoFullName: "org/monitored" }, "me", monitored)).toBe(false);
+  });
+
+  it("returns true for monitored repo item when user is in reviewerLogins", () => {
+    expect(isUserInvolved({ ...base, repoFullName: "org/monitored" }, "me", monitored, ["me"])).toBe(true);
+  });
+
+  it("does not check reviewerLogins when not provided", () => {
+    expect(isUserInvolved({ ...base, repoFullName: "org/monitored" }, "me", monitored)).toBe(false);
+  });
+});
+
 describe("computePageLayout", () => {
   it("returns single page for empty groups", () => {
     const result = computePageLayout([], 10);