fix(ui): preserves scroll position on repo lock/move/unlock

Author: wgordon17

src/app/components/shared/RepoLockControls.tsx

@@ -7,6 +7,12 @@ interface RepoLockControlsProps {
   repoFullName: string;
 }
 
+const withScrollLock = (fn: () => void) => {
+  const y = window.scrollY;
+  fn();
+  window.scrollTo(0, y);
+};
+
 export default function RepoLockControls(props: RepoLockControlsProps) {
   const lockInfo = createMemo(() => {
     const list = viewState.lockedRepos[props.tab];
@@ -26,7 +32,7 @@ export default function RepoLockControls(props: RepoLockControlsProps) {
           <Tooltip content="Pin to top">
             <button
               class="btn btn-ghost btn-xs opacity-0 group-hover/repo-header:opacity-100 focus:opacity-100 max-sm:opacity-60 sm:max-lg:opacity-60 transition-opacity"
-              onClick={() => lockRepo(props.tab, props.repoFullName)}
+              onClick={() => withScrollLock(() => lockRepo(props.tab, props.repoFullName))}
               aria-label={`Pin ${props.repoFullName} to top of list`}
             >
               {/* Heroicons 20px solid: lock-open */}
@@ -40,7 +46,7 @@ export default function RepoLockControls(props: RepoLockControlsProps) {
         <Tooltip content="Unpin">
           <button
             class="btn btn-ghost btn-xs"
-            onClick={() => unlockRepo(props.tab, props.repoFullName)}
+            onClick={() => withScrollLock(() => unlockRepo(props.tab, props.repoFullName))}
             aria-label={`Unpin ${props.repoFullName}`}
           >
             {/* Heroicons 20px solid: lock-closed */}
@@ -52,7 +58,7 @@ export default function RepoLockControls(props: RepoLockControlsProps) {
         <Tooltip content={lockInfo().isFirst ? "Already at top of pinned list" : "Move up"}>
           <button
             class="btn btn-ghost btn-xs"
-            onClick={() => moveLockedRepo(props.tab, props.repoFullName, "up")}
+            onClick={() => withScrollLock(() => moveLockedRepo(props.tab, props.repoFullName, "up"))}
             disabled={lockInfo().isFirst}
             aria-label={`Move ${props.repoFullName} up`}
           >
@@ -65,7 +71,7 @@ export default function RepoLockControls(props: RepoLockControlsProps) {
         <Tooltip content={lockInfo().isLast ? "Already at bottom of pinned list" : "Move down"}>
           <button
             class="btn btn-ghost btn-xs"
-            onClick={() => moveLockedRepo(props.tab, props.repoFullName, "down")}
+            onClick={() => withScrollLock(() => moveLockedRepo(props.tab, props.repoFullName, "down"))}
             disabled={lockInfo().isLast}
             aria-label={`Move ${props.repoFullName} down`}
           >

tests/components/shared/RepoLockControls.test.tsx

@@ -1,4 +1,4 @@
-import { describe, it, expect, vi, beforeEach } from "vitest";
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
 import { render, screen, fireEvent } from "@solidjs/testing-library";
 import RepoLockControls from "../../../src/app/components/shared/RepoLockControls";
 import { resetViewState, viewState, lockRepo } from "../../../src/app/stores/view";
@@ -105,3 +105,53 @@ describe("RepoLockControls", () => {
     expect(parentClick).not.toHaveBeenCalled();
   });
 });
+
+describe("RepoLockControls — scroll preservation", () => {
+  beforeEach(() => {
+    resetViewState();
+    document.documentElement.scrollTop = 500;
+    vi.spyOn(window, "scrollTo");
+  });
+
+  afterEach(() => {
+    vi.restoreAllMocks();
+    document.documentElement.scrollTop = 0;
+  });
+
+  it("preserves scroll position when locking a repo", () => {
+    render(() => (
+      <RepoLockControls tab="issues" repoFullName="owner/repo" />
+    ));
+    fireEvent.click(screen.getByLabelText("Pin owner/repo to top of list"));
+    expect(window.scrollTo).toHaveBeenCalledWith(0, 500);
+  });
+
+  it("preserves scroll position when unlocking a repo", () => {
+    lockRepo("issues", "owner/repo");
+    render(() => (
+      <RepoLockControls tab="issues" repoFullName="owner/repo" />
+    ));
+    fireEvent.click(screen.getByLabelText("Unpin owner/repo"));
+    expect(window.scrollTo).toHaveBeenCalledWith(0, 500);
+  });
+
+  it("preserves scroll position when moving repo up", () => {
+    lockRepo("issues", "owner/a");
+    lockRepo("issues", "owner/b");
+    render(() => (
+      <RepoLockControls tab="issues" repoFullName="owner/b" />
+    ));
+    fireEvent.click(screen.getByLabelText("Move owner/b up"));
+    expect(window.scrollTo).toHaveBeenCalledWith(0, 500);
+  });
+
+  it("preserves scroll position when moving repo down", () => {
+    lockRepo("issues", "owner/a");
+    lockRepo("issues", "owner/b");
+    render(() => (
+      <RepoLockControls tab="issues" repoFullName="owner/a" />
+    ));
+    fireEvent.click(screen.getByLabelText("Move owner/a down"));
+    expect(window.scrollTo).toHaveBeenCalledWith(0, 500);
+  });
+});