Skip to content

Commit 959797e

Browse files
committed
refactor(test): removes misleading comment and redundant vars in S4
1 parent 46a4cc6 commit 959797e

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

tests/acceptance/steps/org-order-stability.steps.tsx

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ const acmeEntry = { login: "acme-corp", avatarUrl: "", type: "org" as const };
4545
const betaEntry = { login: "beta-org", avatarUrl: "", type: "org" as const };
4646
const deltaEntry = { login: "delta-inc", avatarUrl: "", type: "org" as const };
4747

48-
4948
// ── Helper: create one repo per org ──────────────────────────────────────────
5049
function makeOrgRepos(org: string): RepoEntry[] {
5150
return [
@@ -252,21 +251,17 @@ describeFeature(feature, ({ Scenario, Background, BeforeEachScenario, AfterEachS
252251
Given(
253252
'the RepoSelector is displayed with 4 orgs "charlie", "acme-corp", "beta-org", "delta-inc" where "charlie" is the personal org',
254253
async () => {
255-
// Override the auth mock so charlie is the authenticated user
256254
vi.mocked(api.fetchRepos).mockImplementation((_client, org) =>
257255
Promise.resolve(makeOrgRepos(org as string))
258256
);
259257

260-
// charlie is type "user" (personal org), the rest are "org"
261-
const charlieAsPersonal = { login: "charlie", avatarUrl: "", type: "user" as const };
262-
const acme = { login: "acme-corp", avatarUrl: "", type: "org" as const };
263-
const beta = { login: "beta-org", avatarUrl: "", type: "org" as const };
264-
const delta = { login: "delta-inc", avatarUrl: "", type: "org" as const };
258+
// charlie has type "user" — sort puts it first (personal org)
259+
const charlieEntry = { login: "charlie", avatarUrl: "", type: "user" as const };
265260

266261
render(() => (
267262
<RepoSelector
268263
selectedOrgs={["charlie", "acme-corp", "beta-org", "delta-inc"]}
269-
orgEntries={[charlieAsPersonal, acme, beta, delta]}
264+
orgEntries={[charlieEntry, acmeEntry, betaEntry, deltaEntry]}
270265
selected={[]}
271266
onChange={vi.fn()}
272267
/>

0 commit comments

Comments
 (0)