fix(store): fixes resetViewState nested key leak

- fixes Zod+SolidJS interaction where .default({}) reuses refs

- removes wrapper lambdas in ExpandCollapseButtons

- adds pruning, empty-data, round-trip, and filter tests

- adds resetViewState test proving expandedRepos cleared

- renames view.test.ts helper delegating to resetViewState

Author: wgordon17

src/app/components/shared/ExpandCollapseButtons.tsx

@@ -10,7 +10,7 @@ export default function ExpandCollapseButtons(props: ExpandCollapseButtonsProps)
         class="btn btn-ghost btn-xs"
         title="Expand all"
         aria-label="Expand all"
-        onClick={() => props.onExpandAll()}
+        onClick={props.onExpandAll}
       >
         <svg
           xmlns="http://www.w3.org/2000/svg"
@@ -31,7 +31,7 @@ export default function ExpandCollapseButtons(props: ExpandCollapseButtonsProps)
         class="btn btn-ghost btn-xs"
         title="Collapse all"
         aria-label="Collapse all"
-        onClick={() => props.onCollapseAll()}
+        onClick={props.onCollapseAll}
       >
         <svg
           xmlns="http://www.w3.org/2000/svg"

src/app/stores/view.ts

@@ -102,8 +102,19 @@ export const [viewState, setViewState] = createStore<ViewState>(
 );
 
 export function resetViewState(): void {
-  const defaults = ViewStateSchema.parse({});
-  setViewState(defaults);
+  updateViewState({
+    lastActiveTab: "issues",
+    sortPreferences: {},
+    ignoredItems: [],
+    globalFilter: { org: null, repo: null },
+    tabFilters: {
+      issues: { role: "all", comments: "all" },
+      pullRequests: { role: "all", reviewDecision: "all", draft: "all", checkStatus: "all", sizeCategory: "all" },
+      actions: { conclusion: "all", event: "all" },
+    },
+    showPrRuns: false,
+    expandedRepos: { issues: {}, pullRequests: {}, actions: {} },
+  });
 }
 
 export function updateViewState(partial: Partial<ViewState>): void {

tests/components/ActionsTab.test.tsx

@@ -1,7 +1,9 @@
 import { describe, it, expect, beforeEach } from "vitest";
 import { render, screen } from "@solidjs/testing-library";
 import userEvent from "@testing-library/user-event";
+import { createSignal } from "solid-js";
 import ActionsTab from "../../src/app/components/dashboard/ActionsTab";
+import type { WorkflowRun } from "../../src/app/services/api";
 import * as viewStore from "../../src/app/stores/view";
 import { viewState } from "../../src/app/stores/view";
 import { makeWorkflowRun, resetViewStore } from "../helpers/index";
@@ -355,10 +357,41 @@ describe("ActionsTab", () => {
     await user.click(screen.getByRole("button", { name: /Collapse all/i }));
     await user.click(screen.getByRole("button", { name: /Expand all/i }));
 
-    // Workflow card expansion is local state — it resets when repo collapses/re-renders
-    // The key assertion: repo expand/collapse does not affect workflow-level state in viewState
-    // (workflow state is local, not persisted)
+    // Workflow card expansion is local component state (not persisted in viewState)
+    // It survives collapse/expand within the same mount because expandedWorkflows
+    // is at component scope, but would reset on full component remount
     expect(viewState.expandedRepos.actions["owner/repo"]).toBe(true);
+    // Run row still visible — local store persists within same component instance
+    screen.getByText("my-unique-run");
+  });
+
+  it("prunes stale expanded keys when a repo disappears from data", () => {
+    const [runs, setRuns] = createSignal<WorkflowRun[]>([
+      makeWorkflowRun({ repoFullName: "owner/repo-a", workflowId: 1, name: "CI-A" }),
+      makeWorkflowRun({ repoFullName: "owner/repo-b", workflowId: 2, name: "CI-B" }),
+    ]);
+    viewStore.setAllExpanded("actions", ["owner/repo-a", "owner/repo-b"], true);
+    render(() => <ActionsTab workflowRuns={runs()} />);
+
+    // Remove repo-b from data — pruning effect should fire
+    setRuns([makeWorkflowRun({ repoFullName: "owner/repo-a", workflowId: 1, name: "CI-A" })]);
+    expect(viewState.expandedRepos.actions["owner/repo-a"]).toBe(true);
+    expect("owner/repo-b" in viewState.expandedRepos.actions).toBe(false);
+  });
+
+  it("preserves expanded keys when data becomes empty and restores UI on re-population", () => {
+    const [runs, setRuns] = createSignal<WorkflowRun[]>([
+      makeWorkflowRun({ repoFullName: "owner/repo", workflowId: 1, name: "CI" }),
+    ]);
+    viewStore.setAllExpanded("actions", ["owner/repo"], true);
+    render(() => <ActionsTab workflowRuns={runs()} />);
+
+    setRuns([]);
+    expect(viewState.expandedRepos.actions["owner/repo"]).toBe(true);
+
+    // Data returns — UI should use preserved expanded state
+    setRuns([makeWorkflowRun({ repoFullName: "owner/repo", workflowId: 1, name: "CI" })]);
+    expect(screen.getAllByText("CI").length).toBeGreaterThanOrEqual(1);
   });
 
   it("expanded repo state persists in viewState", async () => {

tests/components/IssuesTab.test.tsx

@@ -390,6 +390,33 @@ describe("IssuesTab", () => {
     expect(screen.queryByText("Bob issue")).toBeNull();
   });
 
+  it("collapse all with active filter preserves hidden repos' expanded state", async () => {
+    const user = userEvent.setup();
+    const issues = [
+      makeIssue({ id: 1, title: "Alice issue", repoFullName: "org/repo-a", userLogin: "alice" }),
+      makeIssue({ id: 2, title: "Bob issue", repoFullName: "org/repo-b", userLogin: "bob" }),
+    ];
+    setAllExpanded("issues", ["org/repo-a", "org/repo-b"], true);
+    render(() => <IssuesTab issues={issues} userLogin="alice" />);
+    screen.getByText("Alice issue");
+    screen.getByText("Bob issue");
+
+    // Apply filter hiding repo-b (only alice's issues visible)
+    viewStore.setTabFilter("issues", "role", "author");
+    screen.getByText("Alice issue");
+    expect(screen.queryByText("org/repo-b")).toBeNull();
+
+    // Collapse all — only affects visible (filtered) repos
+    await user.click(screen.getByLabelText("Collapse all"));
+    expect(screen.queryByText("Alice issue")).toBeNull();
+
+    // Remove filter — repo-b should still be expanded (was hidden during collapse-all)
+    viewStore.resetTabFilter("issues", "role");
+    screen.getByText("Bob issue");
+    // repo-a was collapsed by collapse-all
+    expect(screen.queryByText("Alice issue")).toBeNull();
+  });
+
   it("resets page when data shrinks below current page", async () => {
     const user = userEvent.setup();
     updateConfig({ itemsPerPage: 10 });
@@ -490,6 +517,54 @@ describe("IssuesTab", () => {
     screen.getByText("Survives remount");
   });
 
+  it("prunes stale expanded keys when a repo disappears from data", () => {
+    const [issues, setIssues] = createSignal<Issue[]>([
+      makeIssue({ id: 1, title: "Repo A issue", repoFullName: "org/repo-a" }),
+      makeIssue({ id: 2, title: "Repo B issue", repoFullName: "org/repo-b" }),
+    ]);
+    setAllExpanded("issues", ["org/repo-a", "org/repo-b"], true);
+    render(() => <IssuesTab issues={issues()} userLogin="" />);
+    // Both repos expanded
+    screen.getByText("Repo A issue");
+    screen.getByText("Repo B issue");
+
+    // Remove repo-b from data — pruning effect should fire
+    setIssues([makeIssue({ id: 1, title: "Repo A issue", repoFullName: "org/repo-a" })]);
+    expect(viewState.expandedRepos.issues["org/repo-a"]).toBe(true);
+    expect("org/repo-b" in viewState.expandedRepos.issues).toBe(false);
+  });
+
+  it("prunes the first repo key when it disappears (name-based, not positional)", () => {
+    const [issues, setIssues] = createSignal<Issue[]>([
+      makeIssue({ id: 1, title: "Repo A issue", repoFullName: "org/repo-a" }),
+      makeIssue({ id: 2, title: "Repo B issue", repoFullName: "org/repo-b" }),
+    ]);
+    setAllExpanded("issues", ["org/repo-a", "org/repo-b"], true);
+    render(() => <IssuesTab issues={issues()} userLogin="" />);
+
+    // Remove repo-a (first), keep repo-b (second)
+    setIssues([makeIssue({ id: 2, title: "Repo B issue", repoFullName: "org/repo-b" })]);
+    expect("org/repo-a" in viewState.expandedRepos.issues).toBe(false);
+    expect(viewState.expandedRepos.issues["org/repo-b"]).toBe(true);
+  });
+
+  it("preserves expanded keys when data becomes empty and restores UI on re-population", () => {
+    const [issues, setIssues] = createSignal<Issue[]>([
+      makeIssue({ id: 1, title: "Issue A", repoFullName: "org/repo-a" }),
+    ]);
+    setAllExpanded("issues", ["org/repo-a"], true);
+    render(() => <IssuesTab issues={issues()} userLogin="" />);
+    screen.getByText("Issue A");
+
+    // Data becomes empty (e.g. loading state) — expanded state should be preserved
+    setIssues([]);
+    expect(viewState.expandedRepos.issues["org/repo-a"]).toBe(true);
+
+    // Data returns — UI should use preserved expanded state
+    setIssues([makeIssue({ id: 1, title: "Issue A", repoFullName: "org/repo-a" })]);
+    screen.getByText("Issue A");
+  });
+
   it("clicking 'Expand all' expands repos on other pages too", async () => {
     const user = userEvent.setup();
     updateConfig({ itemsPerPage: 10 });

tests/components/PullRequestsTab.test.tsx

@@ -570,6 +570,38 @@ describe("PullRequestsTab", () => {
     screen.getByText("Persistent PR");
   });
 
+  it("prunes stale expanded keys when a repo disappears from data", () => {
+    const [prs, setPrs] = createSignal<PullRequest[]>([
+      makePullRequest({ id: 1, title: "Repo A PR", repoFullName: "org/repo-a" }),
+      makePullRequest({ id: 2, title: "Repo B PR", repoFullName: "org/repo-b" }),
+    ]);
+    setAllExpanded("pullRequests", ["org/repo-a", "org/repo-b"], true);
+    render(() => <PullRequestsTab pullRequests={prs()} userLogin="" />);
+    screen.getByText("Repo A PR");
+    screen.getByText("Repo B PR");
+
+    // Remove repo-b from data — pruning effect should fire
+    setPrs([makePullRequest({ id: 1, title: "Repo A PR", repoFullName: "org/repo-a" })]);
+    expect(viewStore.viewState.expandedRepos.pullRequests["org/repo-a"]).toBe(true);
+    expect("org/repo-b" in viewStore.viewState.expandedRepos.pullRequests).toBe(false);
+  });
+
+  it("preserves expanded keys when data becomes empty and restores UI on re-population", () => {
+    const [prs, setPrs] = createSignal<PullRequest[]>([
+      makePullRequest({ id: 1, title: "PR A", repoFullName: "org/repo-a" }),
+    ]);
+    setAllExpanded("pullRequests", ["org/repo-a"], true);
+    render(() => <PullRequestsTab pullRequests={prs()} userLogin="" />);
+    screen.getByText("PR A");
+
+    setPrs([]);
+    expect(viewStore.viewState.expandedRepos.pullRequests["org/repo-a"]).toBe(true);
+
+    // Data returns — UI should use preserved expanded state
+    setPrs([makePullRequest({ id: 1, title: "PR A", repoFullName: "org/repo-a" })]);
+    screen.getByText("PR A");
+  });
+
   it("clicking 'Expand all' expands repos on other pages too", async () => {
     const user = userEvent.setup();
     updateConfig({ itemsPerPage: 10 });

tests/stores/view.test.ts

@@ -3,6 +3,7 @@ import { createRoot } from "solid-js";
 import {
   viewState,
   updateViewState,
+  resetViewState,
   ignoreItem,
   unignoreItem,
   setSortPreference,
@@ -44,20 +45,12 @@ Object.defineProperty(globalThis, "localStorage", {
   configurable: true,
 });
 
-const defaultState = ViewStateSchema.parse({});
-
-function resetViewState() {
-  updateViewState({
-    lastActiveTab: defaultState.lastActiveTab,
-    sortPreferences: {},
-    ignoredItems: [],
-    globalFilter: { org: null, repo: null },
-    expandedRepos: { issues: {}, pullRequests: {}, actions: {} },
-  });
+function resetForTest() {
+  resetViewState();
 }
 
 beforeEach(() => {
-  resetViewState();
+  resetForTest();
   localStorageMock.clear();
 });
 
@@ -243,6 +236,14 @@ describe("expandedRepos helpers", () => {
     expect(viewState.expandedRepos.issues["owner/c"]).toBe(true);
   });
 
+  it("setAllExpanded with empty array is a no-op", () => {
+    setAllExpanded("issues", ["owner/existing"], true);
+    setAllExpanded("issues", [], true);
+    expect(viewState.expandedRepos.issues["owner/existing"]).toBe(true);
+    setAllExpanded("issues", [], false);
+    expect(viewState.expandedRepos.issues["owner/existing"]).toBe(true);
+  });
+
   it("setAllExpanded with expanded=false deletes all keys (sparse record)", () => {
     setAllExpanded("issues", ["owner/a", "owner/b"], true);
     setAllExpanded("issues", ["owner/a", "owner/b"], false);
@@ -289,3 +290,19 @@ describe("expandedRepos helpers", () => {
     vi.useRealTimers();
   });
 });
+
+describe("resetViewState", () => {
+  it("clears dynamically-added expandedRepos keys", () => {
+    setAllExpanded("issues", ["org/repo-a", "org/repo-b"], true);
+    setAllExpanded("pullRequests", ["org/repo-c"], true);
+    toggleExpandedRepo("actions", "org/repo-d");
+    expect(viewState.expandedRepos.issues["org/repo-a"]).toBe(true);
+
+    resetViewState();
+
+    expect("org/repo-a" in viewState.expandedRepos.issues).toBe(false);
+    expect("org/repo-b" in viewState.expandedRepos.issues).toBe(false);
+    expect("org/repo-c" in viewState.expandedRepos.pullRequests).toBe(false);
+    expect("org/repo-d" in viewState.expandedRepos.actions).toBe(false);
+  });
+});