Skip to content

Commit d4ecda3

Browse files
wgordon17wgordon17
committed
fix(ui): moves repo link outside button, uses focus-visible
1 parent bfe745c commit d4ecda3

File tree

3 files changed

+30
-33
lines changed

3 files changed

+30
-33
lines changed

‎src/app/components/dashboard/ActionsTab.tsx‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -296,17 +296,6 @@ export default function ActionsTab(props: ActionsTabProps) {
296296
>
297297
<ChevronIcon size="md" rotated={!isExpanded()} />
298298
{repoGroup.repoFullName}
299-
<a
300-
href={`https://github.com/${repoGroup.repoFullName}/actions`}
301-
target="_blank"
302-
rel="noopener noreferrer"
303-
onClick={(e) => e.stopPropagation()}
304-
class="opacity-0 group-hover/repo-header:opacity-100 focus-visible:opacity-100 transition-opacity text-base-content/40 hover:text-primary"
305-
title={`Open ${repoGroup.repoFullName} actions on GitHub`}
306-
aria-label={`Open ${repoGroup.repoFullName} actions on GitHub`}
307-
>
308-
<ExternalLinkIcon />
309-
</a>
310299
<Show when={!isExpanded()}>
311300
<span class="ml-auto text-xs font-normal text-base-content/60">
312301
{collapsedSummary().total} workflow{collapsedSummary().total !== 1 ? "s" : ""}
@@ -331,6 +320,16 @@ export default function ActionsTab(props: ActionsTabProps) {
331320
</span>
332321
</Show>
333322
</button>
323+
<a
324+
href={`https://github.com/${repoGroup.repoFullName}/actions`}
325+
target="_blank"
326+
rel="noopener noreferrer"
327+
class="opacity-0 group-hover/repo-header:opacity-100 focus-visible:opacity-100 transition-opacity text-base-content/40 hover:text-primary px-1"
328+
title={`Open ${repoGroup.repoFullName} actions on GitHub`}
329+
aria-label={`Open ${repoGroup.repoFullName} actions on GitHub`}
330+
>
331+
<ExternalLinkIcon />
332+
</a>
334333
<RepoLockControls tab="actions" repoFullName={repoGroup.repoFullName} />
335334
</div>
336335
<Show when={!isExpanded() && peekUpdates().get(repoGroup.repoFullName)}>

‎src/app/components/dashboard/IssuesTab.tsx‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -332,17 +332,6 @@ export default function IssuesTab(props: IssuesTabProps) {
332332
<Show when={monitoredRepoNameSet().has(repoGroup.repoFullName)}>
333333
<span class="badge badge-xs badge-ghost" aria-label="monitoring all activity">Monitoring all</span>
334334
</Show>
335-
<a
336-
href={`https://github.com/${repoGroup.repoFullName}/issues`}
337-
target="_blank"
338-
rel="noopener noreferrer"
339-
onClick={(e) => e.stopPropagation()}
340-
class="opacity-0 group-hover/repo-header:opacity-100 focus-visible:opacity-100 transition-opacity text-base-content/40 hover:text-primary"
341-
title={`Open ${repoGroup.repoFullName} issues on GitHub`}
342-
aria-label={`Open ${repoGroup.repoFullName} issues on GitHub`}
343-
>
344-
<ExternalLinkIcon />
345-
</a>
346335
<Show when={!isExpanded()}>
347336
<span class="ml-auto flex items-center gap-2 text-xs font-normal text-base-content/60">
348337
<span>{repoGroup.items.length} {repoGroup.items.length === 1 ? "issue" : "issues"}</span>
@@ -360,6 +349,16 @@ export default function IssuesTab(props: IssuesTabProps) {
360349
</span>
361350
</Show>
362351
</button>
352+
<a
353+
href={`https://github.com/${repoGroup.repoFullName}/issues`}
354+
target="_blank"
355+
rel="noopener noreferrer"
356+
class="opacity-0 group-hover/repo-header:opacity-100 focus-visible:opacity-100 transition-opacity text-base-content/40 hover:text-primary px-1"
357+
title={`Open ${repoGroup.repoFullName} issues on GitHub`}
358+
aria-label={`Open ${repoGroup.repoFullName} issues on GitHub`}
359+
>
360+
<ExternalLinkIcon />
361+
</a>
363362
<RepoLockControls tab="issues" repoFullName={repoGroup.repoFullName} />
364363
</div>
365364
<Show when={isExpanded()}>

‎src/app/components/dashboard/PullRequestsTab.tsx‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -431,17 +431,6 @@ export default function PullRequestsTab(props: PullRequestsTabProps) {
431431
<Show when={monitoredRepoNameSet().has(repoGroup.repoFullName)}>
432432
<span class="badge badge-xs badge-ghost" aria-label="monitoring all activity">Monitoring all</span>
433433
</Show>
434-
<a
435-
href={`https://github.com/${repoGroup.repoFullName}/pulls`}
436-
target="_blank"
437-
rel="noopener noreferrer"
438-
onClick={(e) => e.stopPropagation()}
439-
class="opacity-0 group-hover/repo-header:opacity-100 focus-visible:opacity-100 transition-opacity text-base-content/40 hover:text-primary"
440-
title={`Open ${repoGroup.repoFullName} pull requests on GitHub`}
441-
aria-label={`Open ${repoGroup.repoFullName} pull requests on GitHub`}
442-
>
443-
<ExternalLinkIcon />
444-
</a>
445434
<Show when={!isExpanded()}>
446435
<span class="ml-auto flex items-center gap-2 text-xs font-normal text-base-content/60 shrink-0">
447436
<span>{repoGroup.items.length} {repoGroup.items.length === 1 ? "PR" : "PRs"}</span>
@@ -501,6 +490,16 @@ export default function PullRequestsTab(props: PullRequestsTabProps) {
501490
</span>
502491
</Show>
503492
</button>
493+
<a
494+
href={`https://github.com/${repoGroup.repoFullName}/pulls`}
495+
target="_blank"
496+
rel="noopener noreferrer"
497+
class="opacity-0 group-hover/repo-header:opacity-100 focus-visible:opacity-100 transition-opacity text-base-content/40 hover:text-primary px-1"
498+
title={`Open ${repoGroup.repoFullName} pull requests on GitHub`}
499+
aria-label={`Open ${repoGroup.repoFullName} pull requests on GitHub`}
500+
>
501+
<ExternalLinkIcon />
502+
</a>
504503
<RepoLockControls tab="pullRequests" repoFullName={repoGroup.repoFullName} />
505504
</div>
506505
<Show when={!isExpanded() && peekUpdates().get(repoGroup.repoFullName)}>

0 commit comments

Comments
 (0)