fix: excludes Dep Dashboard from summary, adds missing tests

Author: wgordon17

src/app/components/dashboard/PersonalSummaryStrip.tsx

@@ -25,14 +25,15 @@ export default function PersonalSummaryStrip(props: PersonalSummaryStripProps) {
     return ids;
   });
 
-  // Single-pass over issues to count assigned (excludes ignored)
+  // Single-pass over issues to count assigned (excludes ignored + Dep Dashboard)
   const issueCounts = createMemo(() => {
     const login = props.userLogin.toLowerCase();
     if (!login) return { assignedIssues: 0 };
     const ignored = ignoredIds();
     let assignedIssues = 0;
     for (const i of props.issues) {
       if (ignored.has(String(i.id))) continue;
+      if (viewState.hideDepDashboard && i.title === "Dependency Dashboard") continue;
       if (i.assigneeLogins.some((a) => a.toLowerCase() === login)) assignedIssues++;
     }
     return { assignedIssues };

tests/components/dashboard/IssuesTab.test.tsx

@@ -29,7 +29,7 @@ vi.mock("../../../src/app/lib/url", () => ({
 // ── Imports ───────────────────────────────────────────────────────────────────
 
 import IssuesTab from "../../../src/app/components/dashboard/IssuesTab";
-import { setTabFilter, setAllExpanded, resetViewState } from "../../../src/app/stores/view";
+import { viewState, setTabFilter, setAllExpanded, resetViewState } from "../../../src/app/stores/view";
 import type { TrackedUser } from "../../../src/app/stores/config";
 
 // ── Setup ─────────────────────────────────────────────────────────────────────
@@ -545,3 +545,51 @@ describe("IssuesTab — scope filter with undefined surfacedBy (non-monitored re
     screen.getByText("Legacy issue");
   });
 });
+
+// ── IssuesTab — scope chip visibility ──────────────────────────────────────
+
+describe("IssuesTab — scope chip visibility", () => {
+  it("does not show Scope chip when no monitored repos and no tracked users", () => {
+    const issues = [makeIssue({ id: 1, title: "Issue", repoFullName: "org/repo", surfacedBy: ["me"] })];
+
+    const { container } = render(() => (
+      <IssuesTab issues={issues} userLogin="me" monitoredRepos={[]} />
+    ));
+
+    expect(container.textContent).not.toContain("Scope:");
+  });
+
+  it("shows Scope chip when monitored repos exist", () => {
+    const issues = [makeIssue({ id: 1, title: "Issue", repoFullName: "org/repo", surfacedBy: ["me"] })];
+
+    const { container } = render(() => (
+      <IssuesTab issues={issues} userLogin="me" monitoredRepos={[{ owner: "org", name: "mon", fullName: "org/mon" }]} />
+    ));
+
+    expect(container.textContent).toContain("Scope:");
+  });
+
+  it("shows Scope chip when tracked users exist (allUsers > 1)", () => {
+    const issues = [makeIssue({ id: 1, title: "Issue", repoFullName: "org/repo", surfacedBy: ["me"] })];
+
+    const { container } = render(() => (
+      <IssuesTab issues={issues} userLogin="me" monitoredRepos={[]}
+        allUsers={[{ login: "me", label: "Me" }, { login: "other", label: "other" }]}
+      />
+    ));
+
+    expect(container.textContent).toContain("Scope:");
+  });
+
+  it("auto-resets scope to involves_me when scope chip becomes hidden", () => {
+    setTabFilter("issues", "scope", "all");
+    expect(viewState.tabFilters.issues.scope).toBe("all");
+
+    // Render with no monitored repos and no tracked users — scope chip hidden, effect should reset
+    render(() => (
+      <IssuesTab issues={[]} userLogin="me" monitoredRepos={[]} />
+    ));
+
+    expect(viewState.tabFilters.issues.scope).toBe("involves_me");
+  });
+});

tests/components/dashboard/PersonalSummaryStrip.test.tsx

@@ -5,7 +5,7 @@ import PersonalSummaryStrip from "../../../src/app/components/dashboard/Personal
 import IssuesTab from "../../../src/app/components/dashboard/IssuesTab";
 import PullRequestsTab from "../../../src/app/components/dashboard/PullRequestsTab";
 import type { Issue, PullRequest, WorkflowRun } from "../../../src/app/services/api";
-import { viewState, setAllExpanded, ignoreItem } from "../../../src/app/stores/view";
+import { viewState, updateViewState, setAllExpanded, ignoreItem } from "../../../src/app/stores/view";
 
 // ── Setup ─────────────────────────────────────────────────────────────────────
 
@@ -699,3 +699,25 @@ describe("PersonalSummaryStrip — excludes ignored items", () => {
     expect(blockedButton.textContent).toContain("1");
   });
 });
+
+describe("PersonalSummaryStrip — hideDepDashboard exclusion", () => {
+  it("excludes Dependency Dashboard issues from assigned count when hideDepDashboard is true", () => {
+    const issues = [
+      makeIssue({ id: 1, title: "Dependency Dashboard", assigneeLogins: ["me"] }),
+    ];
+    // hideDepDashboard defaults to true via resetViewStore
+
+    const { container } = renderStrip({ issues });
+    expect(container.innerHTML).toBe("");
+  });
+
+  it("includes Dependency Dashboard issues when hideDepDashboard is false", () => {
+    updateViewState({ hideDepDashboard: false });
+    const issues = [
+      makeIssue({ id: 1, title: "Dependency Dashboard", assigneeLogins: ["me"] }),
+    ];
+
+    renderStrip({ issues });
+    screen.getByText(/assigned/);
+  });
+});

tests/components/dashboard/PullRequestsTab.test.tsx

@@ -29,7 +29,7 @@ vi.mock("../../../src/app/lib/url", () => ({
 // ── Imports ───────────────────────────────────────────────────────────────────
 
 import PullRequestsTab from "../../../src/app/components/dashboard/PullRequestsTab";
-import { setTabFilter, setAllExpanded, resetViewState } from "../../../src/app/stores/view";
+import { viewState, setTabFilter, setAllExpanded, resetViewState } from "../../../src/app/stores/view";
 import type { TrackedUser } from "../../../src/app/stores/config";
 
 // ── Setup ─────────────────────────────────────────────────────────────────────
@@ -473,3 +473,62 @@ describe("PullRequestsTab — star count in repo headers", () => {
     expect(container.textContent).not.toContain("★");
   });
 });
+
+// ── PullRequestsTab — scope chip visibility ────────────────────────────────
+
+describe("PullRequestsTab — scope chip visibility", () => {
+  it("does not show Scope chip when no monitored repos and no tracked users", () => {
+    const prs = [makePullRequest({ id: 1, title: "PR", repoFullName: "org/repo", surfacedBy: ["me"] })];
+
+    const { container } = render(() => (
+      <PullRequestsTab pullRequests={prs} userLogin="me" monitoredRepos={[]} />
+    ));
+
+    expect(container.textContent).not.toContain("Scope:");
+  });
+
+  it("shows Scope chip when monitored repos exist", () => {
+    const prs = [makePullRequest({ id: 1, title: "PR", repoFullName: "org/repo", surfacedBy: ["me"] })];
+
+    const { container } = render(() => (
+      <PullRequestsTab pullRequests={prs} userLogin="me"
+        monitoredRepos={[{ owner: "org", name: "mon", fullName: "org/mon" }]}
+      />
+    ));
+
+    expect(container.textContent).toContain("Scope:");
+  });
+
+  it("auto-resets scope to involves_me when scope chip becomes hidden", () => {
+    setTabFilter("pullRequests", "scope", "all");
+    expect(viewState.tabFilters.pullRequests.scope).toBe("all");
+
+    render(() => (
+      <PullRequestsTab pullRequests={[]} userLogin="me" monitoredRepos={[]} />
+    ));
+
+    expect(viewState.tabFilters.pullRequests.scope).toBe("involves_me");
+  });
+});
+
+// ── PullRequestsTab — blocked composite filter ────────────────────────────
+
+describe("PullRequestsTab — checkStatus=blocked filter", () => {
+  it("shows both failure and conflict PRs when checkStatus=blocked", () => {
+    const prs = [
+      makePullRequest({ id: 1, title: "Failing PR", repoFullName: "org/repo", checkStatus: "failure", surfacedBy: ["me"], enriched: true }),
+      makePullRequest({ id: 2, title: "Conflict PR", repoFullName: "org/repo", checkStatus: "conflict", surfacedBy: ["me"], enriched: true }),
+      makePullRequest({ id: 3, title: "Passing PR", repoFullName: "org/repo", checkStatus: "success", surfacedBy: ["me"], enriched: true }),
+    ];
+    setTabFilter("pullRequests", "checkStatus", "blocked");
+    setAllExpanded("pullRequests", ["org/repo"], true);
+
+    render(() => (
+      <PullRequestsTab pullRequests={prs} userLogin="me" monitoredRepos={[]} />
+    ));
+
+    screen.getByText("Failing PR");
+    screen.getByText("Conflict PR");
+    expect(screen.queryByText("Passing PR")).toBeNull();
+  });
+});

tests/lib/reorderHighlight.test.ts

@@ -210,4 +210,56 @@ describe("createReorderHighlight", () => {
     disposeRoot();
     vi.useRealTimers();
   });
+
+  it("suppresses highlight when filter key changes simultaneously with reorder", () => {
+    let highlighted!: Accessor<ReadonlySet<string>>;
+    let setOrder!: (v: string[]) => void;
+    let setFilterKey!: (v: string) => void;
+    let disposeRoot!: () => void;
+
+    createRoot((dispose) => {
+      const [order, _setOrder] = createSignal<string[]>(["a", "b", "c"]);
+      const [locked] = createSignal<string[]>([]);
+      const [ignored] = createSignal(0);
+      const [filterKey, _setFilterKey] = createSignal("initial");
+      setOrder = _setOrder;
+      setFilterKey = _setFilterKey;
+      highlighted = createReorderHighlight(order, locked, ignored, filterKey);
+      disposeRoot = dispose;
+    });
+
+    // Reorder AND filter change in single batch — should suppress
+    batch(() => {
+      setFilterKey("changed");
+      setOrder(["c", "a", "b"]);
+    });
+    expect(highlighted().size).toBe(0);
+
+    // Next reorder without filter change — should highlight
+    setOrder(["b", "c", "a"]);
+    expect(highlighted().size).toBeGreaterThan(0);
+
+    disposeRoot();
+  });
+
+  it("highlights normally when getFilterKey is not provided", () => {
+    let highlighted!: Accessor<ReadonlySet<string>>;
+    let setOrder!: (v: string[]) => void;
+    let disposeRoot!: () => void;
+
+    createRoot((dispose) => {
+      const [order, _setOrder] = createSignal<string[]>(["a", "b", "c"]);
+      const [locked] = createSignal<string[]>([]);
+      const [ignored] = createSignal(0);
+      setOrder = _setOrder;
+      // No getFilterKey argument — optional parameter
+      highlighted = createReorderHighlight(order, locked, ignored);
+      disposeRoot = dispose;
+    });
+
+    setOrder(["c", "a", "b"]);
+    expect(highlighted().size).toBeGreaterThan(0);
+
+    disposeRoot();
+  });
 });