test: adds RepoGitHubLink tests and formatDuration NaN guard

Author: wgordon17

src/app/lib/format.ts

@@ -64,7 +64,7 @@ export function formatDuration(startedAt: string, completedAt: string | null): s
   if (!startedAt) return "--";
   if (!completedAt) return "--";
   const diffMs = Date.parse(completedAt) - Date.parse(startedAt);
-  if (diffMs <= 0) return "--";
+  if (isNaN(diffMs) || diffMs <= 0) return "--";
   const totalSec = Math.floor(diffMs / 1000);
   const h = Math.floor(totalSec / 3600);
   const m = Math.floor((totalSec % 3600) / 60);

tests/components/RepoGitHubLink.test.tsx

@@ -0,0 +1,43 @@
+import { describe, it, expect } from "vitest";
+import { render } from "@solidjs/testing-library";
+import RepoGitHubLink from "../../src/app/components/shared/RepoGitHubLink";
+
+describe("RepoGitHubLink", () => {
+  it("renders issues link with correct href and label", () => {
+    const { container } = render(() => (
+      <RepoGitHubLink repoFullName="owner/repo" section="issues" />
+    ));
+    const link = container.querySelector("a")!;
+    expect(link.getAttribute("href")).toBe("https://github.com/owner/repo/issues");
+    expect(link.getAttribute("aria-label")).toBe("Open owner/repo issues on GitHub");
+    expect(link.getAttribute("target")).toBe("_blank");
+    expect(link.getAttribute("rel")).toBe("noopener noreferrer");
+  });
+
+  it("renders pulls link with correct href and label", () => {
+    const { container } = render(() => (
+      <RepoGitHubLink repoFullName="owner/repo" section="pulls" />
+    ));
+    const link = container.querySelector("a")!;
+    expect(link.getAttribute("href")).toBe("https://github.com/owner/repo/pulls");
+    expect(link.getAttribute("aria-label")).toBe("Open owner/repo pull requests on GitHub");
+  });
+
+  it("renders actions link with correct href and label", () => {
+    const { container } = render(() => (
+      <RepoGitHubLink repoFullName="owner/repo" section="actions" />
+    ));
+    const link = container.querySelector("a")!;
+    expect(link.getAttribute("href")).toBe("https://github.com/owner/repo/actions");
+    expect(link.getAttribute("aria-label")).toBe("Open owner/repo actions on GitHub");
+  });
+
+  it("renders ExternalLinkIcon SVG with aria-hidden", () => {
+    const { container } = render(() => (
+      <RepoGitHubLink repoFullName="owner/repo" section="issues" />
+    ));
+    const svg = container.querySelector("svg");
+    expect(svg).not.toBeNull();
+    expect(svg!.getAttribute("aria-hidden")).toBe("true");
+  });
+});

tests/lib/format.test.ts

@@ -226,6 +226,11 @@ describe("formatDuration", () => {
   it("returns '<1s' for sub-second duration", () => {
     expect(formatDuration("2026-03-21T10:00:00.000Z", "2026-03-21T10:00:00.500Z")).toBe("<1s");
   });
+
+  it("returns '--' for invalid date strings", () => {
+    expect(formatDuration("not-a-date", "2026-03-21T10:00:00Z")).toBe("--");
+    expect(formatDuration("2026-03-21T10:00:00Z", "not-a-date")).toBe("--");
+  });
 });
 
 describe("prSizeCategory", () => {

tests/stores/view.test.ts

@@ -190,6 +190,7 @@ describe("ViewStateSchema", () => {
     expect(result.sortPreferences).toEqual({});
     expect(result.ignoredItems).toEqual([]);
     expect(result.globalFilter).toEqual({ org: null, repo: null });
+    expect(result.hideDepDashboard).toBe(true);
   });
 
   it("handles missing fields with defaults", () => {