-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathRefactoredMenu.java
More file actions
83 lines (70 loc) · 1.74 KB
/
Copy pathRefactoredMenu.java
File metadata and controls
83 lines (70 loc) · 1.74 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
//Remove Duplicate Imports
//Before
import java.util.ArrayList;
import java.util.ArrayList;
import java.text.SimpleDateFormat;
import java.text.SimpleDateFormat;
//after
import java.util.ArrayList;
import java.util.Date;
//Encapsulation of Fields
//before
Customer e;
CustomerAccount acc = new CustomerAccount();
//after
private Customer currentCustomer;
private CustomerAccount selectedAccount;
//Extract Method – Customer Search
//before
for (Customer aCustomer: customerList){
if(aCustomer.getCustomerID().equals(customerID))
{
found = true;
customer = aCustomer;
}
}
//after
private Customer findCustomer(String id) {
for(Customer c : customerList) {
if(c.getCustomerID().equals(id)) {
return c;
}
}
return null;
}
//Improve Variable Naming
//Before
Customer e;
CustomerAccount acc;
//After
Customer currentCustomer;
CustomerAccount selectedAccount;
//Simplifying Customer Login Logic
//Before
boolean found = false;
Customer customer = null;
for (Customer aCustomer: customerList){
if(aCustomer.getCustomerID().equals(customerID))
{
found = true;
customer = aCustomer;
}
}
//After
Customer customer = findCustomer(customerID);
if(customer == null){
JOptionPane.showMessageDialog(null, "Customer not found");
return;
}
//Simplified Transaction Recording
//Before
Date date = new Date();
String date2 = date.toString();
String type = "Lodgement";
double amount = balance;
AccountTransaction transaction = new AccountTransaction(date2, type, amount);
acc.getTransactionList().add(transaction);
//After
AccountTransaction transaction =
new AccountTransaction(new Date().toString(), "Lodge", value);
acc.getTransactionList().add(transaction);