Error installing planarity on Windows

[TSOTOF]

I have a problem when installing this package into my computer:

pip install planarity

At the beginning I got the following error:

After installing Visual Studio 2022, the error changed to this:

I ask my friend to install planarity in his Windows computer and he got the same error with me.
I checked my envirment variables, path 'C:\Program Files\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.41.34120\bin\HostX86\x64\cl.exe' is included.
I uninstlled my Visual Studio and changed it's file from Program Files(x86) to Program Files, but it didn't work.
I tried to download the package and directly install it, which also failed.
In the end I turn to networkx.is_planar, but this function is based on python and it is too slow.
Is there any suggestions for my problem?

[hagberg]

Hi Houming, That error (missing unistd.h) is caused by compiling CommandLine.c. That file isn't needed. It is removed in the latest release https://pypi.org/project/planarity/#files. or you can just remove it in your copy and recompile Best Wishes, Aric

…

On Mon, Sep 23, 2024 at 9:09 PM 沈厚名(Shen Houming) ***@***.***> wrote: I have a problem when installing this package into my computer: pip install planarity At the beginning I got the following error: 2dfa9f5697c487aa65de00a71fbef9f.png (view on web) <https://github.com/user-attachments/assets/366cec3e-afa9-4f47-9e0e-23de1540f368> After installing Visual Studio 2022, the error changed to this: 2024-09-24.105214.jpg (view on web) <https://github.com/user-attachments/assets/3f791836-1fbf-4767-b6d4-5ebb853f516c> I ask my friend to install planarity in his Windows computer and he got the same error with me. I checked my envirment variables, path 'C:\Program Files\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.41.34120\bin\HostX86\x64\cl.exe' is included. I uninstlled my Visual Studio and changed it's file from Program Files(x86) to Program Files, but it didn't work. I tried to download the package and directly install it, which also failed. In the end I turn to networkx.is_planar, but this function is based on python and it is too slow. Is there any suggestions for my problem? — Reply to this email directly, view it on GitHub <#17>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABN3Y66KZOVJU4CGKDLFDTZYDJVVAVCNFSM6AAAAABOXKEC6CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DIMJWG42DQMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[TSOTOF]

Thank you so much!
I didn't realize my problem is the same with #15 before.
I downloaded the latest release https://pypi.org/project/planarity/#files and installed it, but I got the same error(missing unistd.h). I tried #15 and it workd really well!

This problem seems common on Windows when compling codes written on Linux or Unix.
Why don't we simply put file unistd.h and getopt.h into path 'planarity\src'?I know few about C++, but #15 seems to be a good solution.

[wbkboyer]

Hi @TSOTOF ! I have re-opened #15 with a proposed fix, and have prepared PR #18 🎉

[john-boyer-phd]

Hi @TSOTOF ! I have re-opened #15 with a proposed fix, and have prepared PR #18 🎉

You have a good fix for #15 and I will be merging it momentarily. I think we should leave this issue open, though, until we are able to deploy an upgraded package to PyPI because the original poster of the issue was trying to do pip install planarity rather than from a local build. Regardless, good work getting the HEAD code back to build/link-ability.