From 4e248fe5694d81c9f3ab9134d448a05d3fbf6b28 Mon Sep 17 00:00:00 2001 From: Horimoto Yasuhiro Date: Thu, 2 Feb 2023 17:52:02 +0900 Subject: [PATCH] Detect a memory leak as a test failure Normally, grntest detect a memory leak as a test failure. However, grntest may return success even if grntest detect memory leak if we specify the --n-retries option. Because grntest return success when a test successful even once while retry test. I modification that grntest return false when a test fail cause of memory leak even once in this PR. --- lib/grntest/worker.rb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/grntest/worker.rb b/lib/grntest/worker.rb index 6ed51f8..1a35e90 100644 --- a/lib/grntest/worker.rb +++ b/lib/grntest/worker.rb @@ -35,6 +35,10 @@ def n_failed_tests @failed_tests.size end + def n_leaked_tests + @n_leaked_tests + end + def on_test_finish @n_tests += 1 end @@ -181,6 +185,7 @@ def run_test(test_script_path, test_name) runner = TestRunner.new(@tester, self) return true if runner.run + return false if @result.n_leaked_tests > 0 if n < @tester.n_retries and not interruptted? @result.cancel_test_failure(test_name)