Skip to content

Commit 84f13c1

Browse files
committed
rename contributor profile
1 parent 34e4f10 commit 84f13c1

3 files changed

Lines changed: 12 additions & 26 deletions

File tree

dotcom-rendering/src/components/ContributorProfile.importable.tsx renamed to dotcom-rendering/src/components/FollowButtonsWithContributorProfile.importable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ const containsText = (html: string) => {
9292
return htmlWithoutTags.length > 0;
9393
};
9494

95-
export const ContributorProfile = ({
95+
export const FollowButtonWithContributorProfile = ({
9696
id,
9797
displayName,
9898
avatarUrl,

dotcom-rendering/src/components/ContributorProfile.stories.tsx renamed to dotcom-rendering/src/components/FollowButtonsWithContributorProfile.stories.tsx

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,14 @@ import {
44
space,
55
textEgyptian14,
66
} from '@guardian/source/foundations';
7-
import { splitTheme } from '../../.storybook/decorators/splitThemeDecorator';
87
import { ArticleDesign, ArticleDisplay, Pillar } from '../lib/articleFormat';
98
import { palette } from '../palette';
109
import { Avatar } from './Avatar';
11-
import { ContributorProfile } from './ContributorProfile.importable';
10+
import { FollowButtonWithContributorProfile } from './FollowButtonsWithContributorProfile.importable';
1211
import { FollowTagButtonPill } from './FollowButtons';
1312

1413
export default {
15-
component: ContributorProfile,
14+
component: FollowButtonWithContributorProfile,
1615
title: 'Components/ContributorProfile',
1716
};
1817

@@ -34,15 +33,15 @@ const containerStyles = css`
3433
padding: 16px;
3534
`;
3635

37-
const opinionDecorator = splitTheme([
36+
const opinionDecorator = [
3837
{
3938
display: ArticleDisplay.Standard,
4039
design: ArticleDesign.Comment,
4140
theme: Pillar.Opinion,
4241
},
43-
]);
42+
];
4443

45-
const allPillarsDecorator = splitTheme([
44+
const allPillarsDecorator = [
4645
{
4746
display: ArticleDisplay.Standard,
4847
design: ArticleDesign.Comment,
@@ -68,12 +67,12 @@ const allPillarsDecorator = splitTheme([
6867
design: ArticleDesign.Comment,
6968
theme: Pillar.Lifestyle,
7069
},
71-
]);
70+
];
7271

7372
// Component stories
7473
export const WithAvatarAndBio = () => (
7574
<div css={containerStyles}>
76-
<ContributorProfile
75+
<FollowButtonWithContributorProfile
7776
id={mockContributor.id}
7877
displayName={mockContributor.displayName}
7978
avatarUrl={mockContributor.avatarUrl}
@@ -86,7 +85,7 @@ WithAvatarAndBio.decorators = [opinionDecorator];
8685

8786
export const WithoutAvatar = () => (
8887
<div css={containerStyles}>
89-
<ContributorProfile
88+
<FollowButtonWithContributorProfile
9089
id={mockContributor.id}
9190
displayName={mockContributor.displayName}
9291
bio={mockContributor.bio}
@@ -96,22 +95,9 @@ export const WithoutAvatar = () => (
9695
WithoutAvatar.storyName = 'Without Avatar';
9796
WithoutAvatar.decorators = [opinionDecorator];
9897

99-
export const AllPillars = () => (
100-
<div css={containerStyles}>
101-
<ContributorProfile
102-
id={mockContributor.id}
103-
displayName={mockContributor.displayName}
104-
avatarUrl={mockContributor.avatarUrl}
105-
bio={mockContributor.bio}
106-
/>
107-
</div>
108-
);
109-
AllPillars.storyName = 'All Pillars';
110-
AllPillars.decorators = [allPillarsDecorator];
111-
11298
export const LongBio = () => (
11399
<div css={containerStyles}>
114-
<ContributorProfile
100+
<FollowButtonWithContributorProfile
115101
id="profile/marina-hyde"
116102
displayName="Marina Hyde"
117103
avatarUrl={mockContributor.avatarUrl}

dotcom-rendering/src/layouts/CommentLayout.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { ArticleTitle } from '../components/ArticleTitle';
1717
import { Border } from '../components/Border';
1818
import { Carousel } from '../components/Carousel.importable';
1919
import { ContributorAvatar } from '../components/ContributorAvatar';
20-
import { ContributorProfile } from '../components/ContributorProfile.importable';
20+
import { FollowButtonWithContributorProfile } from '../components/FollowButtonsWithContributorProfile.importable';
2121
import { DiscussionLayout } from '../components/DiscussionLayout';
2222
import { Footer } from '../components/Footer';
2323
import { GridItem } from '../components/GridItem';
@@ -652,7 +652,7 @@ export const CommentLayout = (props: WebProps | AppsProps) => {
652652
priority="feature"
653653
defer={{ until: 'visible' }}
654654
>
655-
<ContributorProfile
655+
<FollowButtonWithContributorProfile
656656
id={soleContributor.id}
657657
displayName={
658658
soleContributor.title

0 commit comments

Comments
 (0)