Skip to content

Commit 91fc753

Browse files
author
Juarez Mota
committed
fix: remove height constraint and add vertical margin to banner visual containers at desktop breakpoint
Remove `height: 100%` from tablet breakpoint and add `margin: ${space[6]}px 0` at desktop breakpoint for visual container styling. Apply changes consistently across DesignableBanner, v2/Banner, and v2/BannerVisual components.
1 parent a92a944 commit 91fc753

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -901,10 +901,10 @@ const styles = {
901901
justify-self: center;
902902
}
903903
${from.tablet} {
904-
height: 100%;
905904
width: 100%;
906905
}
907906
${from.desktop} {
907+
margin: ${space[6]}px 0;
908908
justify-self: end;
909909
}
910910
${between.desktop.and.wide} {

dotcom-rendering/src/components/marketing/banners/designableBanner/v2/Banner.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,10 +191,10 @@ const styles = {
191191
justify-self: center;
192192
}
193193
${from.tablet} {
194-
height: 100%;
195194
width: 100%;
196195
}
197196
${from.desktop} {
197+
margin: ${space[6]}px 0;
198198
justify-self: end;
199199
}
200200
${between.desktop.and.wide} {

dotcom-rendering/src/components/marketing/banners/designableBanner/v2/components/BannerVisual.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { css } from '@emotion/react';
2-
import { between, from } from '@guardian/source/foundations';
2+
import { between, from, space } from '@guardian/source/foundations';
33
import type { Image } from '@guardian/support-dotcom-components/dist/shared/types';
44
import type { ImageAttrs } from '../../../../shared/ResponsiveImage';
55
import { ResponsiveImage } from '../../../../shared/ResponsiveImage';
@@ -58,10 +58,10 @@ const getStyles = (isHeaderImage = false) => {
5858
justify-self: center;
5959
}
6060
${from.tablet} {
61-
height: 100%;
6261
width: 100%;
6362
}
6463
${from.desktop} {
64+
margin: ${space[6]}px 0;
6565
justify-self: end;
6666
}
6767
${between.desktop.and.wide} {

0 commit comments

Comments
 (0)