Decide what to do regarding edition in MatchInfo

[alexduf]

Here's the situation:

• MAPI always receives the edition as a path parameter, such as /uk/item/....
• DCAR needs the edition in order to properly render dates (timezones are a function of the edition)
• mobile-sports does NOT have any notion of edition in its routes
• we have ongoing work to add DCAR support for sports related pages, such as match-info, which in MAPI has traditionally been edition-less

That leaves us with a few options, none of which are satisfying:

• add support for editions in mobile-sport. This is possibly the cleanest solution, but also a massive endeavour:
  • Deprecate all the existing competition and match routes. Assume if these are accessed they are UK
  • Create new routes with edition
  • Identify all the places where these endpoints refer to each other and ensure the edition is propagated
  • Update the ALB routing behaviour to ensure editionalised endpoints are properly routed to the mobile-sport service
  • Finally, pass the edition during the DCAR
• Add a workaround in the native apps:
  • If a DCAR link does not contain the edition query param, append the edition query param to the URL. This could either be a generic rule applied blindlessly to all DCAR URLs, or a template that needs filling, similar to how image sizes are handled.

Update 2016-03-11, after meeting with apps team and webX:

During the conversation we noted that fastly was already inferring the edition, and injecting it as a header, X-GU-Edition. See logic here

This means in the absence of providing the edition query param to frontend, fastly will provide its best guess as to what edition should be shown to the user. Given that the ONLY impact of this on the match-information feature will be the way a the start date is formatted when a game hasn't happen yet, it seems like a very reasonable solution: do nothing.

[marjisound]

Having a chat with @jamesmockett we think it's best to provide the edition from the app, rather than leaving it for fastly to decide based on the geo location. We want a consistent behaviour between the dates in football live blog & match report and match info pages.

Also we want to stay consistent, so if the user has chosen an edition in the app, that should be used across all pages. And the edition is not just used for dates. Lots of things we run on a page that use the edition.