From 80f571047d9f5142cbfcb90fb5aa4641c943f634 Mon Sep 17 00:00:00 2001 From: Taras Dubyk Date: Mon, 13 Oct 2025 16:30:19 +0300 Subject: [PATCH 1/3] fix db name parsing --- reverse_engineering/helpers/parseConnectionString.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reverse_engineering/helpers/parseConnectionString.js b/reverse_engineering/helpers/parseConnectionString.js index 9cbea92..ddf77c2 100644 --- a/reverse_engineering/helpers/parseConnectionString.js +++ b/reverse_engineering/helpers/parseConnectionString.js @@ -33,7 +33,7 @@ const parseSqlServerUrl = ({ url = '' }) => { return { host, port: port ? Number(port) : null, - databaseName: params.databaseName, + databaseName: params.databaseName || params.database, userName: params.user, userPassword: params.password, }; From 4092d119da94e815f2911c36afba9f4d487dc51f Mon Sep 17 00:00:00 2001 From: Taras Dubyk Date: Mon, 13 Oct 2025 16:33:15 +0300 Subject: [PATCH 2/3] adjust connection parameters for Azure Entra ID --- .../connectionSettingsModalConfig.json | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json b/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json index 32a1300..6f42d80 100644 --- a/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json +++ b/reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json @@ -53,6 +53,7 @@ { "inputLabel": "Host", "inputKeyword": "host", + "inputPlaceholder": "Host", "description": "Specify Azure Synapse server name", "inputType": "text", "dependency": { @@ -117,7 +118,7 @@ }, { "value": "Azure Active Directory (MFA)", - "label": "Azure Active Directory (MFA)" + "label": "Azure Entra ID (MFA)" } ] }, @@ -155,17 +156,7 @@ "inputTooltip": "Specify the Tenant ID from the Overview screen of your Azure AD tenant", "dependency": { "key": "authMethod", - "value": ["Azure Active Directory (Username / Password)", "Azure Active Directory (MFA)"] - } - }, - { - "inputLabel": "User Name", - "inputKeyword": "loginHint", - "inputType": "text", - "inputPlaceholder": "User Name", - "dependency": { - "key": "authMethod", - "value": ["Azure Active Directory (MFA)"] + "value": ["Azure Active Directory (Username / Password)"] } } ] From 54dd1ac8230d570e82d6317a3c07c10b3816a4c4 Mon Sep 17 00:00:00 2001 From: Taras Dubyk Date: Mon, 13 Oct 2025 16:35:03 +0300 Subject: [PATCH 3/3] remove unused msal-node package --- package-lock.json | 5 ++--- package.json | 3 +-- reverse_engineering/databaseService/helpers/connection.js | 1 - 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index 45a14c8..5adf9e8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,14 +1,13 @@ { "name": "Synapse", - "version": "0.2.22", + "version": "0.2.23", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "Synapse", - "version": "0.2.22", + "version": "0.2.23", "dependencies": { - "@azure/msal-node": "3.8.0", "@hackolade/fetch": "1.3.0", "base64url": "3.0.1", "crypto": "1.0.1", diff --git a/package.json b/package.json index 83da090..7351009 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,6 @@ "icon_url": "logo.jpg", "disabled": false, "dependencies": { - "@azure/msal-node": "3.8.0", "@hackolade/fetch": "1.3.0", "base64url": "3.0.1", "crypto": "1.0.1", @@ -80,4 +79,4 @@ "prettier": "3.2.5", "simple-git-hooks": "2.11.1" } -} \ No newline at end of file +} diff --git a/reverse_engineering/databaseService/helpers/connection.js b/reverse_engineering/databaseService/helpers/connection.js index 65d6eba..e5a069e 100644 --- a/reverse_engineering/databaseService/helpers/connection.js +++ b/reverse_engineering/databaseService/helpers/connection.js @@ -1,6 +1,5 @@ const { hckFetch } = require('@hackolade/fetch'); const sql = require('mssql'); -const msal = require('@azure/msal-node'); const { logAuthTokenInfo, logConnectionHostAndUsername } = require('../../helpers/logInfo'); const { prepareError } = require('./errorService'); const { parseResponse } = require('../../helpers/parseResponse');