diff --git a/.github/workflows/changeset-check.yml b/.github/workflows/changeset-check.yml index 43d870a..2289007 100644 --- a/.github/workflows/changeset-check.yml +++ b/.github/workflows/changeset-check.yml @@ -43,7 +43,7 @@ jobs: - name: Get pnpm store directory shell: bash run: | - echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV + echo "STORE_PATH=$(pnpm store path --silent)" >> "$GITHUB_ENV" - name: Setup pnpm cache uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5 @@ -59,9 +59,11 @@ jobs: - name: Check for changeset env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # Attacker-controlled text. Passed through the environment so it is + # never expanded into this step's shell source. + PR_TITLE: ${{ github.event.pull_request.title }} + PR_BRANCH: ${{ github.event.pull_request.head.ref }} run: | - PR_TITLE="${{ github.event.pull_request.title }}" - PR_BRANCH="${{ github.event.pull_request.head.ref }}" BASE_SHA="${{ github.event.pull_request.base.sha }}" HEAD_SHA="${{ github.event.pull_request.head.sha }}" MERGE_BASE=$(git merge-base "$BASE_SHA" "$HEAD_SHA")