Skip to content

configurable limit in searchDef #34

@goolord

Description

@goolord

currently, searchDef is implemented like
https://github.com/wz1000/HieDb/blob/bb7367f513eb17b4e81ed1339b8a583bfc521326/src/HieDb/Query.hs#L121-L126
the LIMIT on line 126 is problematic for HLS's workspace symbol handler, since it frequently omits symbols from a workspace_symbols query in a way that's opaque to the user
https://github.com/haskell/haskell-language-server/blob/3be343acf76f05fb9b8adb73625439a5d40b362c/ghcide/src/Development/IDE/Core/Actions.hs#L123-L127

I think it's fine to either

  1. remove the LIMIT line
  2. add a Maybe Int parameter or similar to make this limit configurable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions