pg 0.18 compatibility

[y8]

Rails 5 already switched to pg 0.18.

I'll keep this issue as a reminder that we will need 0.18 version of this gem in the future.

Right now this version fails with when used with Rails 5.0:

uninitialized constant PG::TypeMapByClass

[danielrhodes]

Also having this problem @headius. Any chance we are going to see updates to this Gem in the near feature?

[andy-twosticks]

I'm also getting:

 uninitialized constant PG::BasicTypeMapForQueries

[jvshahid]

I don't have the time to maintain this gem anymore. @headius any chance someone else can do it ? or may be someone on this thread ? I'm happy to answer questions and/or accept the prs if someone is willing to give it a try

[brianbroderick]

@jvshahid how much work do you think is involved in upgrading to 0.18 compatibility?

[jvshahid]

All the type mappings were written in C in the pg gem, so we can either implement in Ruby for the jruby fork or in Java. This plus wiring them up with the current implementation.

[headius]

@jvshahid Sorry to see you go but we appreciate how much work you have done!

Can anyone do a quick diff to see how much has changed in pg 0.18?

[larskanis]

0.18.0 was a huge code change. The diff-stat between 0.17.1 and 0.18.0 is as follows:

 ext/pg.c                             |  159 ++++++-
 ext/pg.h                             |  238 +++++++++-
 ext/pg_binary_decoder.c              |  160 +++++++
 ext/pg_binary_encoder.c              |  160 +++++++
 ext/pg_coder.c                       |  479 +++++++++++++++++++
 ext/pg_connection.c                  | 1401 +++++++++++++++++++++++++++++++++++---------------------
 ext/pg_copy_coder.c                  |  561 +++++++++++++++++++++++
 ext/pg_errors.c                      |    6 +
 ext/pg_result.c                      |  605 +++++++++++++++++++-----
 ext/pg_text_decoder.c                |  422 +++++++++++++++++
 ext/pg_text_encoder.c                |  663 +++++++++++++++++++++++++++
 ext/pg_type_map.c                    |  159 +++++++
 ext/pg_type_map_all_strings.c        |  116 +++++
 ext/pg_type_map_by_class.c           |  239 ++++++++++
 ext/pg_type_map_by_column.c          |  312 +++++++++++++
 ext/pg_type_map_by_mri_type.c        |  284 ++++++++++++
 ext/pg_type_map_by_oid.c             |  355 ++++++++++++++
 ext/pg_type_map_in_ruby.c            |  302 ++++++++++++
 ext/util.c                           |  149 ++++++
 ext/util.h                           |   65 +++
 lib/pg.rb                            |   12 +-
 lib/pg/basic_type_mapping.rb         |  399 ++++++++++++++++
 lib/pg/coder.rb                      |   83 ++++
 lib/pg/connection.rb                 |   46 +-
 lib/pg/result.rb                     |   16 +-
 lib/pg/text_decoder.rb               |   42 ++
 lib/pg/text_encoder.rb               |   27 ++
 lib/pg/type_map_by_column.rb         |   15 +
 spec/pg/basic_type_mapping_spec.rb   |  251 ++++++++++
 spec/pg/connection_spec.rb           |  641 +++++++++++++++++---------
 spec/pg/result_spec.rb               |  328 ++++++++-----
 spec/pg/type_map_by_class_spec.rb    |  138 ++++++
 spec/pg/type_map_by_column_spec.rb   |  222 +++++++++
 spec/pg/type_map_by_mri_type_spec.rb |  136 ++++++
 spec/pg/type_map_by_oid_spec.rb      |  149 ++++++
 spec/pg/type_map_in_ruby_spec.rb     |  164 +++++++
 spec/pg/type_map_spec.rb             |   22 +
 spec/pg/type_spec.rb                 |  665 +++++++++++++++++++++++++++
 spec/pg_spec.rb                      |   42 +-
 52 files changed, 9777 insertions(+), 1429 deletions(-)

The changes to ext/pg_connection.c were to 1/3 performance related, 1/3 refactoring (to meet the typecast requirements) and 1/3 for the typecasing itself. Roughly the same for ext/pg_result.c . The spec changes probably show the library changes best.

I already thought about writing the typecast implementation as a wrapper in Ruby for this gem and postgres-pr , but even this is a bunch of work.

A partial implementation of the type mappings, that is just enough to run rails-5 is another option. This is only a fraction of work. Not sure, if it should be implemented as ruby-wrapper or directly in java. I'm sorry, I don't know the JRuby API, so that I probably can not really help for a java port.

[aguywithcode]

I saw this posted on the JRuby website. I'd be willing to help with the translation if someone can give me pointers. New to ruby but have extensive java experience. I think the most portable solution would be a native ruby implementation.

[brianbroderick]

I also may be able to help. I have a lot of Ruby experience, but haven't touched Java for a long time. If a few of us can jump on slack or something, we can come up with a plan to get this done.

[danielrhodes]

Where are we with this now? What can I do to help?

[lephyrius]

What is the diff for: 0.19.0 ?