ssh auth sock not created in clients

[k-worker]

Apologies if I'm missing something, I believe I followed the instructions right but haven't gotten things working yet.

It looks like the ssh key is being added and socket created in the vault vm, but it doesn't seem like the client socket is being created in the client appvm. When I manually re-run /rw/config/rc.local on the client appvm, I get Ncat: bind to ~user/.SSH_AGENT_vault-hax: No such file or directory. QUITTING.. Is there something I missed configuring? What further debug steps should I take?

I'm using qubes 3.2. Vault VM is based off the fedora-23 template, and the client VM is based on the whonix-ws template, both of which are kept updated.

[k-worker]

Did some more poking around. I can get things working, but ONLY if the ssh auth socket is not left around from a previous boot. Something else I noticed is that with the current code from master, it doesn't seem like ncat runs. pgrep ncat doesn't show anything, and the socket isn't created. However, the following change does result in the ncat process running after boot, and a usable socket being created:

if [ "$SSH_VAULT_VM" != "" ]; then
        export SSH_SOCK=~user/.SSH_AGENT_$SSH_VAULT_VM
        rm -f "$SSH_SOCK"
-       sudo -u user /bin/sh -c "umask 177 && ncat -k -l -U '$SSH_SOCK' -c 'qrexec-client-vm $SSH_VAULT_VM qubes.SshAgent' &"
+       sudo -u user /bin/sh -c "umask 177 && ncat -k -l -U ${SSH_SOCK} -c 'qrexec-client-vm ${SSH_VAULT_VM} qubes.SshAgent' &"
 fi

Honestly it's not clear to me why exactly that would work, but it does on my whonix-ws based appvm. All that's left is something to properly clean up the socket file, since it doesn't seem like the rm is doing that for some strange reason.

[cobordism]

I can confirm that this fixes the issue.

m-strasser@ce3016d