BDB contracts patch not working for all contracts

[Morphisor244]

I noticed that not all BDB contracts were generating correctly. The cause is that the tech node patches are being incorrectly addressed. I've fixed the issue on my own install and will provide it here, just so I don't need to fork the whole thing for this. Just replace everything inside the bdb_contracts.cfg file with this:

---

// patch to fix tech requirements in bdb contracts

@CONTRACT_TYPE[BDB_AIMP]:NEEDS[Bluedog_DB]
{
@requirement[TechResearched]
{
@Tech = gptt_mag1
}
}
@CONTRACT_TYPE[BDB_Apollo]:NEEDS[Bluedog_DB]
{
@requirement[AllB]
{
@requirement[TechResearchedA]
{
@Tech = gptt_surface1
}
@requirement[TechResearchedB]
{
@Tech = gptt_liquid2
}
}
}
@CONTRACT_TYPE[BDB_Corona_KH1]:NEEDS[Bluedog_DB]
{
@requirement[TechResearched]
{
@Tech = gptt_film1
}
@requirement[Any]
{
@requirement[TechResearchedB]
{
@Tech = gptt_film2
}
@requirement[TechResearchedC]
{
@Tech = gptt_film3
}
}
}
@CONTRACT_TYPE[BDB_Corona_KH4]:NEEDS[Bluedog_DB]
{
@requirement[Any]
{
@requirement[TechResearchedA]
{
@Tech = gptt_film2
}
@requirement[TechResearchedB]
{
@Tech = gptt_film3
}
}
}
@CONTRACT_TYPE[BDB_Gambit]:NEEDS[Bluedog_DB]
{
@requirement[TechResearched]
{
@Tech = gptt_film2
}
}
@CONTRACT_TYPE[BDB_Gemini_ATV]:NEEDS[Bluedog_DB]
{
@requirement[All]
{
@requirement[TechResearchedA]
{
@Tech = gptt_dock1
}
@requirement[TechResearchedB]
{
@Tech = gptt_scienceMat1
}
}
}
@CONTRACT_TYPE[BDB_Lunar_Orbiter]:NEEDS[Bluedog_DB]
{
@requirement[TechResearched]
{
@Tech = gptt_film2
}
}
@CONTRACT_TYPE[BDB_Mariner]:NEEDS[Bluedog_DB]
{
@requirement[TechResearched]
{
@Tech = gptt_scienceEnv
}
}
@CONTRACT_TYPE[BDB_Nimbus]:NEEDS[Bluedog_DB]
{
@requirement[Any]
{
@requirement[TechResearchedA]
{
@Tech = gptt_atmo2
}
@requirement[TechResearchedB]
{
@Tech = gptt_film4
}
}
}
@CONTRACT_TYPE[BDB_GeoStudy]:NEEDS[Bluedog_DB]
{
@requirement[TechResearched]
{
@Tech = gptt_sciRad1
}
}
@CONTRACT_TYPE[BDB_SolarStudy]:NEEDS[Bluedog_DB]
{
@requirement[Any]
{
@requirement[TechResearchedA]
{
@Tech = gptt_sciRad2
}
@requirement[TechResearchedB]
{
@Tech = gptt_atmo1
}
}
}
@CONTRACT_TYPE[BDB_Ranger_Block2]:NEEDS[Bluedog_DB]
{
@requirement[TechResearched]
{
@Tech = gptt_film2
}
}
@CONTRACT_TYPE[BDB_Ranger]:NEEDS[Bluedog_DB]
{
@requirement[TechResearched]
{
@Tech = gptt_mag1
}
}

[Morphisor244]

I'd like to add that even with fixed unlocks, some contracts are not able to be completed properly. This is because the contracts request certain experiments to be done, that are only unlocked in later tech nodes. For example Mariner can request Microwave spectrum experiment, which is only unlocked at a 300 science node, much later than the rest of the craft and the contract.

IMO it would be much better to group the experiments corresponding to a historical tech level together - BDB already balances science gain by having less-than-complete science returns on earlier models.