-
Notifications
You must be signed in to change notification settings - Fork 283
feat: implement _from_protobuf deserialization for all transaction types #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuval99g
wants to merge
36
commits into
hiero-ledger:main
Choose a base branch
from
yuval99g:feat/implement-from-protobuf-deserialization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
de3f02f
fix: correct _get_transaction_class map keys and missing entries
yuval99g d15785d
feat: implement _from_protobuf for account transactions
yuval99g 216fce8
feat: implement _from_protobuf for token transactions
yuval99g dad80e3
feat: implement _from_protobuf for consensus, file, schedule, and sys…
yuval99g 9ed28ba
test: add _from_protobuf round-trip tests for all transaction types
yuval99g 79a524c
fix: remove duplicate CryptoUpdateTransactionBody import in account_u…
yuval99g 386290b
chore: suppress cyclomatic complexity warnings on _from_protobuf methods
yuval99g e67e7b6
chore: suppress cyclomatic complexity warning on AccountUpdateTransac…
yuval99g bbe3d4a
refactor: move PublicKey imports to module level in _from_protobuf files
yuval99g ec1098a
Merge branch 'main' into feat/implement-from-protobuf-deserialization
yuval99g 95c0360
refactor: move local imports to module level in
yuval99g 49657e7
Merge branch 'main' into feat/implement-from-protobuf-deserialization
yuval99g 5a3e93f
test: update _from_protobuf tests to use Transaction.from_bytes()
yuval99g c01a7ff
test: update _from_protobuf tests to use
yuval99g ca2e7b6
fix: correct PRNG dispatch key from utilPrng to util_prng
yuval99g a258834
fix: add _from_topic_fee_proto for correct topic fee deserialization
yuval99g 87e867b
fix: use Key.from_proto_key() for composite key deserialization
yuval99g 27a1ab0
fix: preserve amount=0 in
yuval99g 9e73dda
fix: validate pending airdrop IDs after _from_protobuf deserialization
yuval99g 193db65
fix: preserve empty memo and False wait_for_expiry in ScheduleCreateT…
yuval99g 2f07aee
fix: use HasField for fileID and normalize contents in FileAppendTran…
yuval99g 97eb501
fix: add HasField validation for required fixed_fee in CustomFixedFee
yuval99g bcf8816
fix: correct AccountCreateTransaction auto_renew_period round-trip
yuval99g d8489a5
fix: preserve absent fields during TopicUpdateTransaction deserializa…
yuval99g dc74961
test: improve round-trip coverage in from_bytes tests
yuval99g 1b40987
Merge branch 'main' into feat/implement-from-protobuf-deserialization
yuval99g def6f8d
feat: implement _from_protobuf for contract, node, ethereum, and prng…
yuval99g 0f9b3e3
fix: remove unused import
yuval99g 8858c14
Merge branch 'main' into feat/implement-from-protobuf-deserialization
yuval99g be7ab5d
fix: remove CryptoKey import as
yuval99g 34d8c18
Merge branch 'main' into feat/implement-from-protobuf-deserialization
yuval99g 64b64ba
Merge branch 'main' into feat/implement-from-protobuf-deserialization
yuval99g 641ffdc
Update token_update_transaction.py
yuval99g f59e80c
Remove unused import for Key from key_utils
yuval99g 673f505
Merge branch 'main' into feat/implement-from-protobuf-deserialization
yuval99g 5f0b320
Merge branch 'main' into feat/implement-from-protobuf-deserialization
yuval99g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.