Fix: Don't cancel bounding box drawing when mouse leaves canvas#14
Open
iwconfig wants to merge 1 commit into
Open
Fix: Don't cancel bounding box drawing when mouse leaves canvas#14iwconfig wants to merge 1 commit into
iwconfig wants to merge 1 commit into
Conversation
When drawing a bounding box, if the cursor leaves the canvas area, the selection is no longer cancelled. Instead: - The box edge is clamped to canvas boundary while outside - Mouse position is tracked globally while outside - Box creation completes normally when mouse re-enters and releases - If released outside canvas, box is created with edge at canvas boundary Implementation details: - Uses isOutside state to track when cursor is outside canvas - Global event handlers only attached when both drawing AND outside canvas - addingRef provides synchronous access to adding state in event handlers - Immediate ref update in createBoundingBox prevents race conditions This improves UX when drawing large boxes that may require the cursor to briefly exit the canvas area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When drawing a bounding box, if the cursor leaves the canvas area, the selection is no longer cancelled. Instead:
Implementation details:
This improves UX when drawing large boxes that may require the cursor to briefly exit the canvas area.