Drop doesn't work in version 2.3

[nehonpa]

Dear PyGui version:

2.3

Python version:

3.8.5

Operating system:

windows 11

My issue/question:

I used the same method to drag and move controls in 2.0, and in 2.3 and 2.3. I found it didn't work, and I couldn't figure out the reason. It certainly works when it is not dynamically created through multiple functions.

Steps to reproduce:

run code

Expected behavior:

Running this code with version 2.0 or below will allow you to move the button normally, but button 1 and button 2.3 will not move; it shows no reaction.

Screenshots:

N/A

Standalone, minimal, complete and verifiable example:

import dearpygui.dearpygui as dpg
dpg.create_context()
dpg.create_viewport(title='123')
print(dpg.get_dearpygui_version())


def set_pos(a, b, c):
    pos = dpg.get_item_pos(c)
    print("set_pos")


def drop(a, b, c):
    print("droping")
    if dpg.does_item_exist(c):
        dpg.set_item_pos(c, dpg.get_mouse_pos())



def move_item(a, b, tag):
    
    print("tag",tag)
    x, y = dpg.get_item_pos(tag)
    foo = dpg.get_item_parent(tag)
    dpg.add_button(width=100, height=100, label=("drop_me"), user_data=tag,
                            pos=[x - 10, y - 10], callback=set_pos, drag_callback=drop,
                            parent=foo, tag="drop_move")

    with dpg.drag_payload(parent="drop_move", user_data=tag):
        dpg.add_text(tag)





def popup(tag):
    with dpg.popup(tag, mousebutton=dpg.mvMouseButton_Right, modal=False,
                        tag=f"popup_{tag}"):
        dpg.add_text(f'[{"item_type"}] {tag}')
        dpg.add_text("Current_control")
        dpg.add_text(tag, tag=f"popup_{tag}_text")
        dpg.add_separator()
        with dpg.group(horizontal=True, width=140, height=30):
            dpg.add_button(label="move_item", user_data=tag, callback=move_item)

        

with dpg.window(label="Tutorial",tag="main_window_1",horizontal_scrollbar=True,no_move=True,width=800,height=600):
    dpg.add_text("xxx", tag="tooltip_parent",)

    dpg.add_button(label="but1", tag="drop_1")
    popup("drop_1")



dpg.setup_dearpygui()
dpg.show_viewport()
dpg.start_dearpygui()

[nehonpa]

import dearpygui.dearpygui as dpg

dpg.create_context()
dpg.create_viewport(title='123')
def function():
print("run?")

def cc(a,b,c):
print("no run?")
# dpg.set_item_pos("drag_1", dpg.get_mouse_pos())

with dpg.window(label="Tutorial",tag="main_window_1",horizontal_scrollbar=True,no_move=True,width=800,height=600):
dpg.add_text("xxx", tag="tooltip_parent")

dpg.add_button(label="but1",tag="drop_1",drop_callback=function)

dpg.add_button(label="but2",tag="drag_tar",drag_callback=cc)
with dpg.drag_payload(parent=dpg.last_item()):
    dpg.add_text("Dragged data")

dpg.setup_dearpygui()
dpg.show_viewport()
dpg.start_dearpygui()

Additionally, I tested the sample code you provided for me previously, and it was successful, just like in 2.3. But the code above is not running properly.

[v-ein]

Please explain how to use your minimum example. Right now, I have to dig into your code to get an idea what I'm supposed to do, and honestly I don't have time for that. Just "run code" doesn't really show the issue.

Overall, try to make it less effort for DPG developers (or any other Open Source developers/maintainers) to work on your issues, this way the maintainers won't be a bottleneck and will be able to handle many more issues for more people.

[nehonpa]

Sorry, first you select the "drop_1" button, right-click on the "move_item" button in the pop-up window, and a square button named "drop_me" will appear. When you drag "drop_me," you will find it ineffective.

[v-ein]

first you select the "drop_1" button

Left-clicking it doesn't really do anything. Okay, I decided to give it another chance and right-clicked it and - voila - a popup opened.

right-click on the "move_item" button in the pop-up window

Right-clicking the "move_item" button does nothing. Okay, I decided to give it another chance... 😂

(where's the drop_me button? 😂)

Yep, I see that the "drop_me" button can't be dragged, but it took quite a while to figure it out.

Might be caused by the same thing as #2651, though I can't tell for sure yet, - we had a change in ImGui item positioning (RestoreImGuiCursor and friends).

Here is a simplified example to recreate it. The "Apple" button can be dragged, whereas the "Abs-pos apple" cannot.

import dearpygui.dearpygui as dpg

dpg.create_context()
dpg.create_viewport(title=f"Test - {dpg.get_dearpygui_version()}, {dpg.__file__}", width=400, height=300)

with dpg.window():
    dpg.set_primary_window(dpg.last_item(), True)

    dpg.add_button(label="Apple", drag_callback=lambda s, a: print(f"dragging {dpg.get_item_label(s)}"))
    with dpg.drag_payload(parent=dpg.last_item()):
        dpg.add_text("Apple being dragged")

    dpg.add_button(label="Abs-pos apple", drag_callback=lambda s, a: print(f"dragging abs-pos {dpg.get_item_label(s)}"), pos=(100, 8))
    with dpg.drag_payload(parent=dpg.last_item()):
        dpg.add_text("Abs-pos apple being dragged")

    with dpg.child_window(drop_callback= lambda: print("dropped to a child window!")):
        dpg.add_text("Bucket - drop here!")
                    
dpg.setup_dearpygui()
dpg.show_viewport()
dpg.show_item_registry()
dpg.start_dearpygui()
dpg.destroy_context()

[nehonpa]

Haha, I found the quality of the translation software to be so low that I completely misunderstood what I wanted to describe.😂

[nehonpa]

Hey, I just discovered another bug. When I accidentally clicked the Hide button in the "Item Registry" with 2.0, it crashed directly.

[nehonpa]

However, this crash will only occur after the program runs and you directly click "Show" or "Hide".

[v-ein]

When I accidentally clicked the Hide button in the "Item Registry" with 2.0, it crashed directly.

Does this happen on 2.3? If yes, please open a separate issue on this.

[nehonpa]

No, 2.3 does not have this phenomenon. It's probably because there was no default selection of a marker in the initial state that the wild pointer was operated on. (I guessed it)
Also, there’s an issue that I’m not sure is caused by my own operation or if it’s an actual bug. When I enable "Item Registry", removing the tag of a listener event from a widget callback can randomly cause a crash. If I perform the deletion without enabling it, this problem does not occur.

[v-ein]

When I enable "Item Registry", removing the tag of a listener event from a widget callback can randomly cause a crash.

Interesting. Can you show the code? Also, is this about 2.3? If it's an earlier version and does not occur in 2.3, it makes little sense to report and discuss it because most likely the crash has already been fixed 😁.

[nehonpa]

No, it is still like that in 2.3. But I need to correct what happened: after creating the pop-up window, I deleted it and removed its monitoring as well. When recreating the same tag, a crash occurs when viewing the control through "Item Registry".
The following example makes it easy to see the phenomenon. First, click the clear button, then click the add button, then click on the "Item Registry" section about mvItemHandler Registry, and you will find that it crashes directly. By the way, 2.0 doesn't seem to have any issues with this operation, but approximate operations can still crash.

import dearpygui.dearpygui as dpg

dpg.create_context()
dpg.create_viewport(title=f"Test - {dpg.get_dearpygui_version()}, {dpg.__file__}", width=400, height=300)
dpg.show_item_registry()

ls = []
def clear():
    for i in ls:
        dpg.delete_item(i)
        if dpg.does_item_exist(f"popup_{i}"):
            dpg.delete_item(f"popup_{i}")
    for i in dpg.get_all_items():
        if dpg.does_item_exist(i):
            dic = dpg.get_item_info(i)
            if dic['type'] in ('mvAppItemType::mvItemHandlerRegistry'):
                for u in dpg.get_item_children(i):
                    if dpg.does_item_exist(u):
                        dpg.delete_item(u)
                dpg.delete_item(i)

    
def popup(tag):
    with dpg.popup(tag, mousebutton=dpg.mvMouseButton_Right, modal=False,
                        tag=f"popup_{tag}"):
        dpg.add_text(f'[{"item_type"}] {tag}')
        dpg.add_text("Current_control")
        dpg.add_text(tag, tag=f"popup_{tag}_text")
        dpg.add_separator()

def add():
    for i in range(20):
        tag =f"{i}_"
        dpg.add_text(i,parent="win",tag=tag)
        popup(tag)
        ls.append(tag)

with dpg.window(tag="win"):
    dpg.set_primary_window(dpg.last_item(), True)

    add()
    dpg.add_button(label="add",callback=add,width=100,height=30)
    dpg.add_button(label="clear",callback=clear,width=100,height=30)
dpg.setup_dearpygui()
dpg.show_viewport()
dpg.show_item_registry()
dpg.start_dearpygui()
dpg.destroy_context()

[v-ein]

You probably had an item selected in Item Registry and then it got deleted by the "clear" button. Yep, if the item selected in Item Registry gets deleted, then you'll likely get a segfault. This is a known issue, though there's no ticket for it, and I'm going to fix it sooner or later. Not critical IMHO (Item Registry is just a helper tool), so it might take some time. Thanks for reporting anyway!