Skip to content

Latest commit

 

History

History
34 lines (27 loc) · 1.16 KB

File metadata and controls

34 lines (27 loc) · 1.16 KB
id DEV-365
title Mark a PR Ready Only When It Is Complete
status active
enforcement manual
severity error
depends_on
DEV-360

Problem

A PR marked ready before it has a reviewer, a preview, or passing CI wastes reviewer time on unfinished work and can merge unchecked.

Solution

Treat "ready for review" as a promise that the PR is complete and only the review remains. Prepare everything first, then flip it, so a reviewer never opens half-finished work.

  1. Assign at least one reviewer.
  2. Include a preview link when the change is visually verifiable.
  3. Mark ready for review only once the PR is a linked, self-assigned draft (per DEV-360) with a reviewer and a preview where applicable.
  4. Resolve all CI checks. CI runs after the PR is marked ready, so do not request approval until it passes.
  5. Do not merge without an approved review and passing CI.

Acceptance Criteria

  • The PR has at least one reviewer and a preview link where applicable
  • It is marked ready only after it is fully prepared
  • CI passes before approval is requested
  • It is not merged without an approved review and passing CI