Skip to content

DEV-410.md

Latest commit

 

History

History
30 lines (23 loc) · 947 Bytes

DEV-410.md

File metadata and controls

30 lines (23 loc) · 947 Bytes
Raw
id DEV-410
title Reject With Request Changes for Objective Problems
status active
enforcement manual
severity error
depends_on
DEV-365

Problem

Leaving a plain comment on a PR that should be rejected does not block the merge, is not recorded as a rejection, and stops the author from re-requesting review. Real problems slip through as if they were optional.

Solution

Match the review action to the finding.

  1. When a PR is not ready to merge, use Request Changes for objective problems: it does not solve the stated problem, it introduces a bug, its code style is inconsistent, or it violates a required guideline.
  2. Use Comment for optional improvements or suggestions that should not block the PR.

Acceptance Criteria

  • Objective problems get Request Changes, not a plain comment
  • Optional suggestions use Comment
  • A rejection names the objective problem it is based on