Skip to content

Latest commit

 

History

History
31 lines (24 loc) · 1.09 KB

File metadata and controls

31 lines (24 loc) · 1.09 KB
id DEV-415
title Re-request Review Explicitly After Addressing Changes
status active
enforcement manual
severity error
depends_on
DEV-410

Problem

After a reviewer requests changes and the author fixes them, without an explicit re-request the reviewer is never notified and the PR keeps its stale "changes requested" state, so it stalls unseen.

Solution

A resolved review is only resolved once the reviewer knows to look again. Closing the loop explicitly is what notifies them and clears the blocking state, so a comment or a fresh push is not enough on its own.

  1. After addressing every requested change, use GitHub's re-request review control on each reviewer who requested changes.
  2. Re-requesting resets that reviewer from "changes requested" to "review requested" and notifies them, so the PR is no longer silently blocked.

Acceptance Criteria

  • Review is explicitly re-requested from each reviewer who requested changes
  • The review state is reset from "changes requested" to "review requested"
  • Readiness is not signaled by a comment or a push alone