Lundi de Pentecôte - France

[chixbv]

I am by no means an expert on this and would readily listen to someone with more expertise on this subject, but since 2008, 'Lundi de Pentecôte' has been included as an official public holiday in France, according the official site of Republic Française, where it is listed at one of the official 11 'jours fériés'

Currently, it listed under the informal flag, but it would be good to get an updated version.

Holidays.between('2024-01-01', '2024-12-31', :fr, :informal)
 =>
[{:date=>Mon, 01 Jan 2024, :name=>"Jour de l'an", :regions=>[:fr]},
 {:date=>Sun, 31 Mar 2024, :name=>"Pâques", :regions=>[:fr]},
 {:date=>Mon, 01 Apr 2024, :name=>"Lundi de Pâques", :regions=>[:fr]},
 {:date=>Wed, 01 May 2024, :name=>"Fête du travail", :regions=>[:fr]},
 {:date=>Wed, 08 May 2024, :name=>"Victoire 1945", :regions=>[:fr]},
 {:date=>Thu, 09 May 2024, :name=>"Ascension", :regions=>[:fr]},
 {:date=>Sun, 19 May 2024, :name=>"Pentecôte", :regions=>[:fr]},
 {:date=>Mon, 20 May 2024, :name=>"Lundi de Pentecôte", :regions=>[:fr]},
 {:date=>Sun, 14 Jul 2024, :name=>"Fête nationale", :regions=>[:fr]},
 {:date=>Thu, 15 Aug 2024, :name=>"Assomption", :regions=>[:fr]},
 {:date=>Fri, 01 Nov 2024, :name=>"Toussaint", :regions=>[:fr]},
 {:date=>Mon, 11 Nov 2024, :name=>"Armistice 1918", :regions=>[:fr]},
 {:date=>Wed, 25 Dec 2024, :name=>"Noël", :regions=>[:fr]}]

Appreciate any feedback or discussion about this.

[DagonWat]

@ppeble an interesting case is brought up... As from what I see in definitions (https://github.com/holidays/definitions/blob/master/fr.yaml):

- name: Pentecôte
  regions: [fr]
  function: easter(year)
  function_modifier: 49
- name: Lundi de Pentecôte
  regions: [fr]
  function: easter(year)
  function_modifier: 50
  type: informal

Pentecôte is counted as regular holiday, but when called Holidays.between('2024-01-01', '2024-12-31', :fr) is not there.

While Lundi de Pentecôte is configured to be informal, when called Holidays.between('2024-01-01', '2024-12-31', :fr) it is there.

I am probably blind but can't see the reason yet why these holidays are configured incorrectly BUT when calling .between correct result shows up. Tests are also looking weird...

By solving that matter I will be able to create a PR with fixes.

[DagonWat]

@chixbv when :informal flag is passed Holidays library is going to return all real Holidays + Informal holidays, so your resulting array is correct, while config file IS NOT, so my above comment stands.