From 886f89d71db9aaeb0ddd82d35f0dac3ba10728d3 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 9 Oct 2022 04:38:24 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../setuptools/tests/test_easy_install.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/lib/python3.9/site-packages/setuptools/tests/test_easy_install.py b/lib/python3.9/site-packages/setuptools/tests/test_easy_install.py index dc00e69..c5539ce 100644 --- a/lib/python3.9/site-packages/setuptools/tests/test_easy_install.py +++ b/lib/python3.9/site-packages/setuptools/tests/test_easy_install.py @@ -539,7 +539,26 @@ def test_setup_requires_override_nspkg(self, use_setup_cfg): foobar_1_dir = os.path.join(temp_dir, 'foo.bar-0.1') os.mkdir(foobar_1_dir) with tarfile.open(foobar_1_archive) as tf: - tf.extractall(foobar_1_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, foobar_1_dir) sys.path.insert(1, foobar_1_dir) dist = PRDistribution(foobar_1_dir, project_name='foo.bar',