From 97f0b8b159310fe21efbeea679322447c01c3d9d Mon Sep 17 00:00:00 2001 From: Prathamesh Jadhav <55660103+lollinng@users.noreply.github.com> Date: Fri, 5 Jun 2026 02:50:46 +0530 Subject: [PATCH] Raise ValueError (not a bare string) in ParallelismConfig.get_device_mesh get_device_mesh raised a string literal when device_type was not provided: `raise ("You need to pass a device_type ...")`. In Python 3 raising a non-exception throws `TypeError: exceptions must derive from BaseException`, hiding the intended guidance. Raise ValueError with the message instead. Co-authored-by: Claude Opus 4.8 (1M context) --- src/accelerate/parallelism_config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/accelerate/parallelism_config.py b/src/accelerate/parallelism_config.py index c4135f2f791..22d15d3678c 100644 --- a/src/accelerate/parallelism_config.py +++ b/src/accelerate/parallelism_config.py @@ -248,7 +248,7 @@ def get_device_mesh(self, device_type: Optional[str] = None): if device_type is not None: self.device_mesh = self.build_device_mesh(device_type) else: - raise ("You need to pass a device_type e.g cuda to build the device mesh") + raise ValueError("You need to pass a device_type e.g cuda to build the device mesh") else: if device_type is not None: if self.device_mesh.device_type != device_type: