diff --git a/.DS_Store b/.DS_Store new file mode 100644 index 0000000..5008ddf Binary files /dev/null and b/.DS_Store differ diff --git a/knowledge_graph/querying.py b/knowledge_graph/querying.py index 78922fb..df18444 100644 --- a/knowledge_graph/querying.py +++ b/knowledge_graph/querying.py @@ -2,6 +2,7 @@ import functools from typing import Callable, Dict, FrozenSet, Iterable, Optional, Tuple +import deprecated import gamla from . import ( @@ -195,9 +196,11 @@ def find_exactly(text: str): ) -title_or_node_id = gamla.first( - get_node_title, storage.node_id, exception_type=NodeTitleMissing +@deprecated.deprecated( + reason="ID can be anything, which makes this function unexpected. Use `get_node_title` or 'node_id' instead." ) +def title_or_node_id(node: storage.Node) -> str: + return gamla.first(get_node_title, storage.node_id, exception_type=NodeTitleMissing)(node) @gamla.curry diff --git a/setup.py b/setup.py index ad7f3f2..39a2d02 100644 --- a/setup.py +++ b/setup.py @@ -31,7 +31,8 @@ packages=setuptools.find_namespace_packages(), install_requires=[ "dataclasses_json==0.5.7", - "immutables", + "deprecated", + "immutables>=0.18", "pytest", "phonenumbers", ],