Update soldoros doll quick item potions#10
Merged
Conversation
- replace Wild Strawberry and Rum with Norton and Lorrain supreme potions - assert quick item ids in soldoros and choro tests - fix Windows fixture path resolution in related tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Soldoros doll APC generation to use new quick-item potion IDs, and strengthens regression coverage in the Soldoros and Choro pipeline tests while fixing Windows fixture path resolution.
Changes:
- Add quick-item ID replacement logic to the Soldoros doll APC document builder.
- Add assertions in Soldoros + Choro pipeline tests to lock in expected quick-item IDs.
- Switch fixture archive path resolution in affected tests to
fileURLToPath(...)for Windows compatibility.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mods/soldoros_doll/src/index.ts | Introduces exported item ID constants and replaces quick-item IDs when building the doll APC document. |
| mods/soldoros_doll/src/index.test.ts | Fixes fixture path resolution and adds regression assertions for quick-item IDs in overlays and applied pipeline output. |
| mods/2_3_choro_partset_skill_up/src/index.test.ts | Fixes fixture path resolution and adds regression assertions for the Soldoros doll quick-item IDs through the Choro pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- accept already-updated quick item ids when rebuilding an existing doll APC - add a regression test for reapplying the soldoros mod in one session Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing