Fix Windows fixture test paths and CI install#11
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Improves cross-platform (Windows) reliability of fixture-based tests and simplifies CI setup by relying on the standard pnpm install lifecycle to prepare required fixtures.
Changes:
- Update test fixture archive path resolution to use
fileURLToPath(new URL(...))for Windows compatibility. - Simplify CI dependency installation by removing
--ignore-scriptsand the separatepnpm preparestep.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/pvf-mod/src/index.test.ts | Uses fileURLToPath for fixture path resolution to avoid Windows path issues. |
| mods/example_wild_strawberry_hp_up/src/index.test.ts | Same fixture path resolution fix for Windows compatibility. |
| .github/workflows/ci.yml | Restores normal pnpm install flow and removes explicit fixture preparation step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile --ignore-scripts | ||
|
|
||
| - name: Prepare fixtures | ||
| run: pnpm prepare | ||
| run: pnpm install --frozen-lockfile |
There was a problem hiding this comment.
Switching from pnpm install --ignore-scripts to a normal pnpm install will now execute lifecycle scripts during CI (notably the root postinstall: husky from package.json). If the goal is primarily to run the fixture preparation, consider disabling husky in CI (e.g., set HUSKY=0 in job env) to avoid unnecessary hook setup and potential CI flakiness/time cost while still allowing prepare to run.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Testing