Skip to content

Fix Windows fixture test paths and CI install#11

Merged
hzy merged 2 commits into
mainfrom
fix/windows-test-paths-and-ci
Apr 10, 2026
Merged

Fix Windows fixture test paths and CI install#11
hzy merged 2 commits into
mainfrom
fix/windows-test-paths-and-ci

Conversation

@hzy
Copy link
Copy Markdown
Owner

@hzy hzy commented Apr 10, 2026

Summary

  • fix Windows fixture archive resolution in tests by using fileURLToPath instead of URL.pathname
  • include the CI workflow change to run the normal pnpm install flow again

Testing

  • pnpm test

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 10, 2026 15:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves cross-platform (Windows) reliability of fixture-based tests and simplifies CI setup by relying on the standard pnpm install lifecycle to prepare required fixtures.

Changes:

  • Update test fixture archive path resolution to use fileURLToPath(new URL(...)) for Windows compatibility.
  • Simplify CI dependency installation by removing --ignore-scripts and the separate pnpm prepare step.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/pvf-mod/src/index.test.ts Uses fileURLToPath for fixture path resolution to avoid Windows path issues.
mods/example_wild_strawberry_hp_up/src/index.test.ts Same fixture path resolution fix for Windows compatibility.
.github/workflows/ci.yml Restores normal pnpm install flow and removes explicit fixture preparation step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines 36 to +37
- name: Install dependencies
run: pnpm install --frozen-lockfile --ignore-scripts

- name: Prepare fixtures
run: pnpm prepare
run: pnpm install --frozen-lockfile
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching from pnpm install --ignore-scripts to a normal pnpm install will now execute lifecycle scripts during CI (notably the root postinstall: husky from package.json). If the goal is primarily to run the fixture preparation, consider disabling husky in CI (e.g., set HUSKY=0 in job env) to avoid unnecessary hook setup and potential CI flakiness/time cost while still allowing prepare to run.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hzy hzy merged commit 418a98c into main Apr 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants