feat(Remove jobs older than a week): Remove monitorable jobs older than a week

Author: br648

src/main/java/com/conveyal/datatools/common/status/MonitorableJob.java

@@ -115,6 +115,7 @@ private void registerJob() {
         Set<MonitorableJob> userJobs = JobUtils.getJobsForUser(this.owner);
         userJobs.add(this);
         JobUtils.userJobsMap.put(retrieveUserId(), userJobs);
+        JobUtils.removeJobsOlderThanAWeek();
     }
 
     @JsonProperty("owner")

src/main/java/com/conveyal/datatools/manager/utils/JobUtils.java

@@ -11,6 +11,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.time.LocalDateTime;
+import java.time.format.DateTimeFormatter;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Map;
@@ -173,4 +175,15 @@ public static DeployJob queueDeployJob(Deployment deployment, Auth0UserProfile o
         deploymentJobsByServer.put(server.id, deployJob);
         return deployJob;
     }
+
+    /**
+     * Removes all jobs that are older than one week.
+     */
+    public static void removeJobsOlderThanAWeek() {
+        LocalDateTime oneWeekAgo = LocalDateTime.now().minusDays(7);
+        userJobsMap.forEach((userId, jobs) ->
+            jobs.removeIf(job -> LocalDateTime.parse(job.status.modified, DateTimeFormatter.ISO_DATE_TIME)
+                .isBefore(oneWeekAgo))
+        );
+    }
 }

src/test/java/com/conveyal/datatools/manager/utils/JobUtilsTest.java

@@ -0,0 +1,51 @@
+package com.conveyal.datatools.manager.utils;
+
+import com.conveyal.datatools.common.status.MonitorableJob;
+import com.google.common.collect.Sets;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.time.Instant;
+import java.util.Set;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+class JobUtilsTest {
+
+    @BeforeEach
+    void setUp() {
+        JobUtils.userJobsMap.clear();
+    }
+
+    @Test
+    void testRemoveJobsOlderThanAWeek() {
+        String userId = "user-id";
+        Set<MonitorableJob> jobs = Sets.newConcurrentHashSet();
+
+        MonitorableJob oldJob = createMonitorableJob();
+        oldJob.status.modified = Instant.now().minus(java.time.Duration.ofDays(8)).toString();
+
+        MonitorableJob recentJob = createMonitorableJob();
+        recentJob.status.modified = Instant.now().toString();
+
+        jobs.add(oldJob);
+        jobs.add(recentJob);
+        JobUtils.userJobsMap.put(userId, jobs);
+
+        JobUtils.removeJobsOlderThanAWeek();
+
+        Set<MonitorableJob> remainingJobs = JobUtils.userJobsMap.get(userId);
+        assertEquals(1, remainingJobs.size());
+        assertTrue(remainingJobs.stream().anyMatch(job -> job.jobId.equals(recentJob.jobId)));
+    }
+
+    private MonitorableJob createMonitorableJob() {
+        return new MonitorableJob() {
+            @Override
+            public void jobLogic() {
+
+            }
+        };
+    }
+}