Skip to content

Commit b14b7d0

Browse files
igerberclaude
andcommitted
Address PR #443 R6 review (2 P3 actionable, docs cleanup)
athey-2025-review.md: - Mark Equation 13 nuclear-norm penalty as resolved (paper text confirms the same unsquared form as Equation 2) - Tighten draft-framing intro: weight normalization is the only remaining open source-ambiguity item wooldridge-2023-review.md: - Replace nonexistent local PDF path with the Econometrics Journal DOI URL so the provenance trail is reproducible from the repo Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 796decd commit b14b7d0

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

docs/methodology/papers/athey-2025-review.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
## Methodology Registry Entry
1111

12-
*Working draft formatted to match docs/methodology/REGISTRY.md structure. Heading levels and labels align with existing entries. Two open source-ambiguity items remain (weight normalization and Eq. 13 penalty form — see "Gaps and Uncertainties" below); resolve those against the source before promoting this section into REGISTRY.md.*
12+
*Working draft formatted to match docs/methodology/REGISTRY.md structure. Heading levels and labels align with existing entries. One open source-ambiguity item remains (weight normalization — see Gap #5 under "Gaps and Uncertainties" below); resolve it against the source before promoting this section into REGISTRY.md.*
1313

1414
## TROP
1515

@@ -351,7 +351,7 @@ The paper uses semi-synthetic simulations (Section 3.1, pages 9-11) based on 6 r
351351

352352
5. **Weight normalization**: Section 5 (page 20) states weights sum to one (`1^T omega = 1^T theta = 1`), but the weight specification in Equation 3 (page 7) uses unnormalized exponential weights. It is unclear whether normalization is applied before or after the optimization, or whether the theoretical results in Section 5 assume normalized weights while the practical algorithm uses unnormalized weights. The existing diff-diff implementation uses unnormalized weights in the optimization (matching Equation 2).
353353

354-
6. **Nuclear norm penalty in Equation 13**: Equation 13's penalty term should be rechecked against pages 26-27 of the PDF to confirm whether it uses the unsquared nuclear norm `lambda_nn ||L||_*` (matching Equation 2) or a squared variant `lambda_nn ||L||_*^2`. The shipped implementation uses the unsquared form per Equation 2.
354+
6. **Nuclear norm penalty in Equation 13** (resolved): the source uses the same unsquared nuclear-norm penalty `lambda_nn ||L||_*` in Equation 13 as in Equation 2 (consistent with the rest of the draft and confirmed against the paper text). The shipped implementation matches.
355355

356356
7. **General assignment patterns**: Section 6.1 generalizes beyond block assignment, but the inference results (Section 5.3) and theoretical guarantees (Theorem 5.1) are stated under block assignment. The extent to which theoretical results carry over to general patterns is not fully characterized.
357357

docs/methodology/papers/wooldridge-2023-review.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
**Authors:** Jeffrey M. Wooldridge
44
**Citation:** Wooldridge, J. M. (2023). Simple approaches to nonlinear difference-in-differences with panel data. *The Econometrics Journal*, 26(3), C31–C66. https://doi.org/10.1093/ectj/utad016
5-
**PDF reviewed:** papers/wooldridge.pdf
5+
**PDF reviewed:** https://doi.org/10.1093/ectj/utad016 (Econometrics Journal — official article URL)
66
**Review date:** 2026-03-21
77

88
---

0 commit comments

Comments
 (0)