docs(v4): review feedback - consumer-propagation gate, honest family framing, API-roster surface

M-091's done-gate now requires consumer propagation, not just marker
membership: BusinessReport must reject marked diagnostics as primary
estimator input BY TYPE (today it special-cases only Bacon by name) and
practitioner_next_steps must route marked diagnostics through diagnostic
handling (not the unknown-result estimator fallback) - consumer files
added to the row's scope. Section 3.5 reframed honestly as a NEW canonical
consolidation anchored on (not identical to) the docs family, with
explicit reclassifications and non-members (Conley is an embedded
inference method, not a diagnostic object). M-090 gains
docs/api/index.rst (which lists Bacon as an estimator today) and a
terminal grouping assertion.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017eVKbBqzenDKa5idwtexQa

Author: igerber

docs/v4-deprecations.yaml

@@ -904,8 +904,8 @@ rows:
     removed_in: null
     status: planned
     phase: 5
-    code_refs: [README.md, diff_diff/guides/llms.txt, diff_diff/bacon.py]
-    notes: "4.0 diagnostic-family docs/roster reorganization (spec section 3.5): Bacon re-homed OUT of the API estimator roster (misfiled today); RDPlot (already documented as a diagnostic) consolidated under the unified family grouping; README/llms.txt/API/alias groupings and estimator-count claims split into estimators + diagnostics. The Phase 2 marker introduction is gated separately by [M-091]."
+    code_refs: [README.md, diff_diff/guides/llms.txt, docs/api/index.rst, diff_diff/bacon.py]
+    notes: "4.0 diagnostic-family docs/roster reorganization (spec section 3.5): Bacon re-homed OUT of the API estimator roster (misfiled today); RDPlot (already documented as a diagnostic) consolidated under the unified family grouping; README/llms.txt/API/alias groupings (incl. docs/api/index.rst, which lists Bacon as an estimator today) and estimator-count claims split into estimators + diagnostics; the flip's terminal test asserts the estimator/diagnostic grouping on the named surfaces. The Phase 2 marker introduction is gated separately by [M-091]."
   - id: M-091
     kind: behavior
     group: diagnostic-family
@@ -916,8 +916,8 @@ rows:
     removed_in: null
     status: planned
     phase: 2
-    code_refs: [diff_diff/bacon.py, diff_diff/rdplot.py, diff_diff/honest_did.py, diff_diff/pretrends.py, diff_diff/power.py, diff_diff/diagnostics.py, diff_diff/had_pretests.py, diff_diff/diagnostic_report.py]
-    notes: "Phase 2 Diagnostic marker base on the RESULT roster (spec section 3.5): BaconDecompositionResults, RDPlotResult, HonestDiDResults + SensitivityResults, PreTrendsPowerResults + PreTrendsPowerCurve, PowerResults + Simulation*Results, PlaceboTestResults, and the HAD pretest containers (QUGTestResults, StuteTestResults, YatchewTestResults, StuteJointResult, HADPretestReport), and DiagnosticReportResults (serialization pair moves/delegates from the builder onto the container). Flip to done requires the dedicated roster test (isinstance + summary/to_dataframe on every member; estimator results NOT marked). Raw-dict functions and TWFEWeightsResult are docs-family only (narrowed, spec section 3.5). introduced_in gates the 3.9 cut: the marker cannot be silently skipped."
+    code_refs: [diff_diff/bacon.py, diff_diff/rdplot.py, diff_diff/honest_did.py, diff_diff/pretrends.py, diff_diff/power.py, diff_diff/diagnostics.py, diff_diff/had_pretests.py, diff_diff/diagnostic_report.py, diff_diff/business_report.py, diff_diff/practitioner.py, diff_diff/_reporting_helpers.py, diff_diff/__init__.py]
+    notes: "Phase 2 Diagnostic marker base on the RESULT roster (spec section 3.5): BaconDecompositionResults, RDPlotResult, HonestDiDResults + SensitivityResults, PreTrendsPowerResults + PreTrendsPowerCurve, PowerResults + Simulation*Results, PlaceboTestResults, and the HAD pretest containers (QUGTestResults, StuteTestResults, YatchewTestResults, StuteJointResult, HADPretestReport), and DiagnosticReportResults (serialization pair moves/delegates from the builder onto the container). Flip to done ALSO requires consumer-propagation tests: BusinessReport rejects marked diagnostics as primary estimator input BY TYPE (not by name), and practitioner_next_steps routes marked diagnostics through diagnostic handling (not the unknown-result estimator fallback). Flip to done requires the dedicated roster test (isinstance + summary/to_dataframe on every member; estimator results NOT marked). Raw-dict functions and TWFEWeightsResult are docs-family only (narrowed, spec section 3.5). introduced_in gates the 3.9 cut: the marker cannot be silently skipped."
 
   # ---- Behavior policies (schema-tracked, spec-governed; no reality probe) -
   - id: M-080

docs/v4-design.md

@@ -158,14 +158,20 @@ it assesses a design, an identifying assumption, or robustness (a
 decomposition table, binned plot data, a pre-trends p-value, sensitivity
 bounds, a power curve).
 
-**Membership = the library's EXISTING "Diagnostics & Sensitivity" docs
-family, formalized** - not a new taxonomy: BaconDecomposition, RDPlot,
-parallel-trends testing, the placebo suite, HonestDiD, PreTrendsPower,
-PowerAnalysis, `twowayfeweights`, the HAD pretests, and the upcoming
-CJM 2020 density test (born into the family). (A narrower classes-only
-tier with separate categories for HonestDiD/PowerAnalysis was drafted and
-REJECTED 2026-07-19: the boundary needed adjudication, and the docs
-family already draws the right line.)
+**Membership: a NEW CANONICAL CONSOLIDATION anchored on the
+"Diagnostics & Sensitivity" docs family** (which today is close but not
+identical - the consolidation is the source of truth from 4.0):
+BaconDecomposition (reclassified OUT of the README/API estimator lists),
+RDPlot (consolidated from the RD grouping), parallel-trends testing, the
+placebo suite, HonestDiD, PreTrendsPower, PowerAnalysis,
+`twowayfeweights`, the HAD pretests, DiagnosticReport's results, and the
+upcoming CJM 2020 density test (born into the family). Explicit
+NON-members despite current docs placement: Conley spatial-HAC (an
+embedded inference method on estimators, not a diagnostic object) and
+other design elements listed under the README section. (A narrower
+classes-only tier with separate categories for HonestDiD/PowerAnalysis
+was drafted and REJECTED 2026-07-19: the boundary needed adjudication,
+and the family line above is the decided one.)
 
 **Mechanics - the marker lives on RESULT containers.** Consumers hold
 results, not entry points, so the `Diagnostic` marker base (shipping
@@ -193,9 +199,14 @@ return raw dicts (`check_parallel_trends` and variants,
 `summary()`/`to_dataframe()` today) participate in the DOCS family only,
 not the type contract; upgrading them to marked containers is optional
 Phase 2 follow-up work, not part of this contract. The Phase 2 gate
-[M-091] requires a dedicated roster test: every enumerated result type is
-`isinstance(result, Diagnostic)` and exposes the serialization pair, and
-representative ESTIMATOR results are NOT. Import paths do NOT move - the
+[M-091] requires a dedicated roster test AND consumer propagation: every
+enumerated result type is `isinstance(result, Diagnostic)` and exposes
+the serialization pair, representative ESTIMATOR results are NOT, and the
+CONSUMERS actually switch to the marker - BusinessReport rejects marked
+diagnostics as its primary estimator input by type (today it
+special-cases only Bacon by name), and `practitioner_next_steps()` routes
+marked diagnostics through diagnostic-specific handling instead of its
+unknown-result estimator fallback. Import paths do NOT move - the
 flat top-level namespace is kept (rejected: `diff_diff.diagnostics.*`
 moves). Zero new classes beyond the single marker.