fix(reviewer-eval): prose block gates on the -z discovery, not quoted name-status (CI codex P1)

touches_notebook() parses non-z name-status text where git's default
core.quotePath C-quotes non-ASCII/special paths — the tab-split
predicate silently missed them, excluding the notebook from the diff
body while never building its prose block. The prose builder's robust
null-delimited --name-only -z discovery is now authoritative (it
returns '' when no tutorial changed). Regression test: a C-quoted
non-ASCII tutorial filename still gets its prose block.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: igerber

tests/test_evals_adapters.py

@@ -416,3 +416,23 @@ def test_notebook_prose_aggregate_cap_is_bytes(tmp_path, monkeypatch):
     assert "--- docs/tutorials/a.ipynb ---" not in block
     assert "AGGREGATE TRUNCATION" in block
     assert "  - docs/tutorials/a.ipynb" in block
+
+
+def test_notebook_prose_built_for_git_quoted_filename(tmp_path):
+    """P1 regression: a tutorial notebook whose path git C-quotes under the
+    default core.quotePath (non-ASCII) must still get its prose block — the
+    prose builder's -z discovery is authoritative, not the quoted
+    name-status text."""
+    from adapters.ci_prompt import build_ci_prompt
+
+    nb = _make_nb([("markdown", "# quoted-path marker PLUGH")])
+    repo, base, head = _init_case_repo(tmp_path, {"docs/tutorials/tütorial-ñb.ipynb": nb})
+    prompt = build_ci_prompt(
+        worktree_dir=repo,
+        base_sha=base,
+        head_sha=head,
+        base_prompt="RULES",
+        extractor_path=_EXTRACTOR,
+    )
+    assert "PLUGH" in prompt
+    assert '<notebook-prose untrusted="true">' in prompt

tools/reviewer-eval/adapters/ci_prompt.py

@@ -332,14 +332,19 @@ def build_ci_prompt(
     """
     name_status = git_name_status(worktree_dir, base_sha, head_sha)
     unified = git_unified_diff(worktree_dir, base_sha, head_sha)
-    prose_block = ""
-    if touches_notebook(name_status):
-        if extractor_path is None:
-            # TRUSTED current-repo extractor (documented divergence from CI's
-            # base-SHA staging) — never the case worktree's copy, which is
-            # case-controlled content.
-            extractor_path = os.path.join(_HARNESS_REPO_ROOT, DEFAULT_EXTRACTOR_RELPATH)
-        prose_block = build_notebook_prose_block(worktree_dir, base_sha, head_sha, extractor_path)
+    if extractor_path is None:
+        # TRUSTED current-repo extractor (documented divergence from CI's
+        # base-SHA staging) — never the case worktree's copy, which is
+        # case-controlled content.
+        extractor_path = os.path.join(_HARNESS_REPO_ROOT, DEFAULT_EXTRACTOR_RELPATH)
+    # Unconditional: the prose builder discovers changed tutorials itself via
+    # the robust null-delimited `--name-only -z` read (returning "" when none
+    # changed). Gating on touches_notebook() would re-parse the NON-`-z`
+    # name-status text, where git's default core.quotePath C-quotes
+    # non-ASCII/special paths and the tab-split predicate silently misses
+    # them — the diff body would exclude the notebook while no prose block
+    # was ever built (CI's -z path handles those names).
+    prose_block = build_notebook_prose_block(worktree_dir, base_sha, head_sha, extractor_path)
     return assemble_prompt(
         base_prompt=base_prompt,
         name_status=name_status,