Skip to content

Commit 19b225d

Browse files
authored
Merge pull request abue-ammar#18 from abue-ammar/logo-fix
feat: update macOS build process to only create DMG files and adjust …
2 parents bcf8c84 + 156b53d commit 19b225d

2 files changed

Lines changed: 15 additions & 20 deletions

File tree

.github/workflows/main.yml

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -95,24 +95,11 @@ jobs:
9595
elif [ "${{ matrix.os }}" = "windows-latest" ]; then
9696
npx tauri build --target ${{ matrix.target }} --bundles nsis,msi
9797
elif [ "${{ matrix.os }}" = "macos-latest" ]; then
98-
npx tauri build --target ${{ matrix.target }} --bundles app
98+
# Build only dmg for macOS
99+
npx tauri build --target ${{ matrix.target }} --bundles dmg
99100
fi
100101
shell: bash
101102

102-
- name: Build DMG (macOS only)
103-
if: matrix.os == 'macos-latest'
104-
run: |
105-
# Try to build DMG, but don't fail the entire job if it fails
106-
echo "Attempting to build DMG..."
107-
if npx tauri build --target ${{ matrix.target }} --bundles dmg; then
108-
echo "DMG build successful"
109-
else
110-
echo "DMG build failed, but continuing with app bundle"
111-
ls -la src-tauri/target/${{ matrix.target }}/release/bundle/ || echo "No bundle directory found"
112-
fi
113-
continue-on-error: true
114-
shell: bash
115-
116103
- name: List Build Output
117104
run: |
118105
echo "Build output structure:"
@@ -343,8 +330,8 @@ jobs:
343330
# Copy desktop builds
344331
find artifacts/windows-build -name "*.exe" -type f -exec cp {} release-files/ \;
345332
find artifacts/windows-build -name "*.msi" -type f -exec cp {} release-files/ \;
346-
find artifacts/macos-intel-build -name "*.app" -type f -exec cp -r {} release-files/ \;
347-
find artifacts/macos-apple-silicon-build -name "*.app" -type f -exec cp -r {} release-files/ \;
333+
find artifacts/macos-intel-build -name "*.dmg" -type f -exec cp {} release-files/ \;
334+
find artifacts/macos-apple-silicon-build -name "*.dmg" -type f -exec cp {} release-files/ \;
348335
find artifacts/linux-build -name "*.deb" -type f -exec cp {} release-files/ \;
349336
find artifacts/linux-build -name "*.AppImage" -type f -exec cp {} release-files/ \;
350337
@@ -376,7 +363,7 @@ jobs:
376363
377364
## Downloads
378365
- **Windows**: Download `.exe` or `.msi` files
379-
- **macOS**: Download `.app` files
366+
- **macOS**: Download `.dmg` files (recommended installer)
380367
- **Linux**: Download `.deb` or `.AppImage` files
381368
- **Android**: Download `.apk` files for direct installation
382369
files: |

src-tauri/tauri.conf.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
"windows": [
1414
{
1515
"title": "image-compressor",
16-
"width": 800,
17-
"height": 600,
16+
"width": 1200,
17+
"height": 800,
1818
"resizable": true,
1919
"fullscreen": false
2020
}
@@ -36,6 +36,14 @@
3636
"android": {
3737
"minSdkVersion": 28,
3838
"versionCode": 100
39+
},
40+
"macOS": {
41+
"dmg": {
42+
"windowSize": {
43+
"width": 660,
44+
"height": 400
45+
}
46+
}
3947
}
4048
},
4149
"plugins": {

0 commit comments

Comments
 (0)