Commit 7d89eea
committed
ci(audience): run Unity-dependent SDK tests via dedicated workflow (SDK-326)
The Unity-dependent test asmdefs in the Audience package were never
discovered by CI: test-audience-sdk.yml runs dotnet test (csproj excludes
Tests/Runtime/Unity/** + Tests/Editor/**), and test-audience-sample-app.yml
runs Unity Test Runner against examples/audience but the project's
manifest.json had no testables entry, so Immutable.Audience.Runtime.Tests
was never compiled by Unity. As a result DeviceCollectorTests shipped with
two compile errors (missing InternalsVisibleTo + a broken 'is not string s'
pattern) that no PR caught.
Closes the gap with:
* New test-audience-sdk-unity.yml — single GameCI Linux cell, Unity 2022.3
with iOS module so UnityEditor.iOS.Xcode + UNITY_IOS resolve. Single cell
on purpose; these tests don't vary by Unity LTS / backend / OS.
* testables entry in examples/audience/Packages/manifest.json so Unity Test
Runner discovers the package's test asmdefs.
* InternalsVisibleTo on Immutable.Audience.Unity for the test asmdef so
DeviceCollectorTests can see internal types.
* Fix the 'is not string s' pattern: the negated form doesn't bind s, so
CS0165 fired on s.Length once compilation actually ran.1 parent e6abbbd commit 7d89eea
5 files changed
Lines changed: 96 additions & 2 deletions
File tree
- .github/workflows
- examples/audience/Packages
- src/Packages/Audience
- Runtime/Unity
- Tests/Runtime/Unity
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
41 | 44 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| |||
0 commit comments