Add link to Aquarium on landing page#2
Open
DikieDick wants to merge 2 commits into
Open
Conversation
Contributor
jim-portegies
left a comment
There was a problem hiding this comment.
Thanks! It's wonderful when we can do this. I am wondering if we can bring it in a bit more prominently.
I'd be happy if we merged this as is, but I think the messaging we want to express here is: If you just want to quickly see what Waterproof is, use the aquarium, if you intend to use it a lot/run your own course/run into performance issues, use the vscode extension. I'm not really sure how to communicate that succinctly. |
Co-authored-by: jim-portegies <36723906+jim-portegies@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a link to Aquarium to the impermeable landing page.
Currently looks like:
Remarks
As a follow up I think we should rework the entire right side, for example the
Installationtext should maybe beh3instead ofh2to indicate this is part of the VSCode extension section. Should we also indicate more clearly that the VSCode extension is the preferred way of using Waterproof?