332 bug lean starting subproof gives scary warning#93
Draft
GitLuckier wants to merge 2 commits into
Draft
Conversation
…like unsolved goals in lean)
…rom the panel when it is part of the input area
Contributor
|
Is there a way we can spawn the error on the QED instead? It doesn't have to be the full/same error as otherwise, but this is what happens when you've normally not finished a proof. Then we're also not showing the full error in the editor, because we only do this in code cells contained in input areas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the vscode side, we now receive the
hideFromBottomPaneldiagnostic message. This is to prevent messages likeunsolved goalsin a subproof from scaring the user by not showing them below an input panel.To test this PR, checkout branch 332-bug-lean-starting-a-subproof-gives-a-scary-warning in
impermeable/waterproof-vscode. Start a subproof by using a\.character. The error message should no longer appear on the bottom of the input area (only if the unsolved goals is inside the input area). Other error messages should be uneffected.This is done to resolve impermeable/waterproof-vscode#332. However, I am not quite satisfied with the result, because it also hides the red squiggly line that would normally appear below the subproof dot. This squiggle shows the user that the subproof has not been solved yet. From the issue description, it wasn't really clear to me what the desired end result was. If desired, I can also show a shorter error message instead of the whole thing. However, if we want to HIDE the error message AND still show the squiggle, the best way (without any hacks) would be to ask the CodeMirror maintainer Marijn if we could do this using the linter. Currently, you can say whether you want the error to show a tooltip, but you cannot prevent it from showing up in the bottom panel (trust me, I tried).
If the current approach is already sufficient and does not need to red squiggle, then please go ahead and merge this.