diff --git a/.basedpyright/baseline.json b/.basedpyright/baseline.json index 0067454d7..d4fcd9f25 100644 --- a/.basedpyright/baseline.json +++ b/.basedpyright/baseline.json @@ -6740,32 +6740,32 @@ { "code": "reportUnknownArgumentType", "range": { - "startColumn": 41, - "endColumn": 42, + "startColumn": 52, + "endColumn": 53, "lineCount": 1 } }, { "code": "reportUnknownArgumentType", "range": { - "startColumn": 41, - "endColumn": 42, + "startColumn": 46, + "endColumn": 47, "lineCount": 1 } }, { "code": "reportUnknownArgumentType", "range": { - "startColumn": 41, - "endColumn": 42, + "startColumn": 52, + "endColumn": 53, "lineCount": 1 } }, { "code": "reportUnknownArgumentType", "range": { - "startColumn": 41, - "endColumn": 42, + "startColumn": 46, + "endColumn": 47, "lineCount": 1 } }, diff --git a/loopy/check.py b/loopy/check.py index 3b48e5434..e9d239ec8 100644 --- a/loopy/check.py +++ b/loopy/check.py @@ -291,8 +291,6 @@ def ensure_depends_only_on_arguments( for tv in kernel.temporary_variables.values(): what = f"offset of temporary '{tv.name}'" - if tv.offset is None: - pass if tv.offset is auto: pass elif isinstance(tv.offset, (int, np.integer, ExpressionNode, str)): @@ -1469,22 +1467,18 @@ def _check_for_unused_hw_axes_in_kernel_chunk( if group_axes != group_axes_used: raise LoopyError( f"instruction '{insn.id}' does not use all group hw axes " - "(available: %s used: %s). " + f"(available: {','.join(str(i) for i in group_axes)} " + f"used: {','.join(str(i) for i in group_axes_used)}). " "Calling loopy.add_inames_for_unused_hw_axes(...) " - "might help." - % ( - ",".join(str(i) for i in group_axes), - ",".join(str(i) for i in group_axes_used))) + "might help.") if local_axes != local_axes_used: raise LoopyError( f"instruction '{insn.id}' does not use all local hw axes " - "(available: %s used: %s). " + f"(available: {','.join(str(i) for i in local_axes)} " + f"used: {','.join(str(i) for i in local_axes_used)}). " "Calling loopy.add_inames_for_unused_hw_axes(...) " - "might help." - % ( - ",".join(str(i) for i in local_axes), - ",".join(str(i) for i in local_axes_used))) + "might help.") elif isinstance(sched_item, (Barrier, EnterLoop, LeaveLoop)): i += 1 diff --git a/loopy/preprocess.py b/loopy/preprocess.py index 764c460b5..cca6bd3fe 100644 --- a/loopy/preprocess.py +++ b/loopy/preprocess.py @@ -241,8 +241,6 @@ def make_args_for_offsets_and_strides(kernel: LoopKernel) -> LoopKernel: for arg in kernel.args: if isinstance(arg, ArrayArg) and not arg._separation_info: what = f"offset for argument '{arg.name}'" - if arg.offset is None: - pass if arg.offset is auto: offset_name = vng(arg.name+"_offset") additional_args.append(ValueArg( @@ -300,8 +298,6 @@ def zero_offsets_and_strides(kernel: LoopKernel) -> LoopKernel: new_args = [] for arg in kernel.args: if isinstance(arg, ArrayArg): - if arg.offset is None: - pass if arg.offset is auto: made_changes = True arg = arg.copy(offset=0)