From daf3f12c23d991c2d7e3a1fd3e6c5feeeb4da46e Mon Sep 17 00:00:00 2001 From: pushiscool Date: Mon, 25 May 2026 21:29:34 -0400 Subject: [PATCH] Make tag display public --- src/cogs/tags.py | 2 +- tests/test_tags.py | 35 ++++++++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/src/cogs/tags.py b/src/cogs/tags.py index afc193b..cd705a5 100644 --- a/src/cogs/tags.py +++ b/src/cogs/tags.py @@ -118,7 +118,7 @@ async def tag_display( if tag_data.get("image_url"): embed.set_image(url=tag_data["image_url"]) - await inter.send(embed=embed, ephemeral=True) + await inter.send(embed=embed, ephemeral=False) @commands.Cog.listener("on_ready") async def tag_on_ready(self) -> None: diff --git a/tests/test_tags.py b/tests/test_tags.py index a52f6f1..9cb0eba 100644 --- a/tests/test_tags.py +++ b/tests/test_tags.py @@ -2,7 +2,7 @@ import copy from types import SimpleNamespace -from cogs.tags import can_upload_tag_image, is_image_attachment, normalize_tag_name +from cogs.tags import Tags, can_upload_tag_image, is_image_attachment, normalize_tag_name from database_handler import TagsDatabase @@ -123,3 +123,36 @@ def test_tags_database_update_is_user_scoped(): assert my_tag["content"] == "updated" assert my_tag["image_url"] == "https://example.com/new.png" assert their_tag["content"] == "theirs" + + +def test_tag_display_success_is_public(): + sent_messages = [] + + class FakeTagStore: + async def get_tag(self, guild_id, user_id, name): + assert guild_id == 1 + assert user_id == 10 + assert name == "kinetics" + return { + "name": "kinetics", + "content": "Stuff", + "image_url": "https://example.com/kinetics.png", + } + + class FakeInteraction: + guild = SimpleNamespace(id=1) + user = SimpleNamespace(id=10) + + async def send(self, *args, **kwargs): + sent_messages.append((args, kwargs)) + + bot = SimpleNamespace(db=SimpleNamespace(tags=FakeTagStore())) + cog = Tags(bot) + + asyncio.run(Tags.tag_display.callback(cog, FakeInteraction(), name="Kinetics")) + + assert len(sent_messages) == 1 + _, kwargs = sent_messages[0] + assert kwargs["ephemeral"] is False + assert kwargs["embed"].title == "kinetics" + assert kwargs["embed"].description == "Stuff"