From 16a2a6e2c41844617145e4f6d0b8521e759cfb3c Mon Sep 17 00:00:00 2001 From: akestler Date: Thu, 29 Sep 2022 15:07:01 -0400 Subject: [PATCH] **Project 1 Review Pull** _-AKK_ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- **_do not merge merge this code_** This is for you to look over and allows us to give direct feedback on your code in addition to a spreadsheet of more quantified grades below is a brief summary, if you compare changes you will see any comments I made in your code highlighted in each file --- **Glows:** :star:️ - excellent game demo and presentation - good use of async await and using a third party api ! - thoroughly planned and followed through to completion, only polish left - implemented complex game logic in a very short amount of time and delivered a playable mvp ! --- **Grows:** :seedling: - code organization can be improved, proper indentation and grouping will help your development process in the future and increase legibility - add comments to your code ! --- Congratulations on a job very well done, keep up the great work Stephanie ! :grin: --- app.js | 7 +++++-- index.html | 6 +++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/app.js b/app.js index c530303..4f00282 100644 --- a/app.js +++ b/app.js @@ -1,4 +1,7 @@ +// there are a lot of global variables and not a lot of comments ! +// well done, blackjack is a pretty complicated game and you handled it very well here +// definitely add more comments, and watch your indentation! const deckUrl = "https://deckofcardsapi.com/api/deck/new/draw/?count=52" let startButton = document.getElementById('fetch-click') let playerBet = document.getElementById('player-button') @@ -30,7 +33,7 @@ playerImgs = document.getElementById('player-imgs') dealerImgs = document.getElementById('dealer-imgs') let betButton = document.getElementById('place-bet') - +// nice use of async and await ! async function getJson(url) { let response = await fetch(url); let data = await response.json() @@ -40,7 +43,7 @@ async function getJson(url) { - +// lots of white space and no comments async function main(){ data = await getJson(deckUrl) deck = data.cards diff --git a/index.html b/index.html index 0aea9f8..5448ae8 100644 --- a/index.html +++ b/index.html @@ -25,10 +25,10 @@
- +

- +
player

@@ -43,7 +43,7 @@

- +