lint

Author: KiKoS0

expr.go

@@ -79,7 +79,7 @@ type AggregateEvaluator[T Evaluable] interface {
 	SlowLen() int
 
 	// Close stops background goroutines and releases resources
-	Close() error
+	Close()
 
 	// PendingDeletes returns the number of soft-deleted items awaiting GC
 	PendingDeletes() int
@@ -284,9 +284,8 @@ func (a *aggregator[T]) SlowLen() int {
 	return len(a.constants)
 }
 
-func (a *aggregator[T]) Close() error {
+func (a *aggregator[T]) Close() {
 	close(a.stopGC)
-	return nil
 }
 
 func (a *aggregator[T]) PendingDeletes() int {

expr_test.go

@@ -855,11 +855,6 @@ func TestAddRemove(t *testing.T) {
 			require.Empty(t, eval)
 			require.EqualValues(t, 0, count)
 		})
-
-		// NOTE: With async GC, Remove() no longer returns an error for non-existent items
-		// It just marks the ID as deleted, and GC handles cleanup
-		// err = e.Remove(ctx, tex(`event.data.another == "i'm not here"`))
-		// require.Error(t, ErrEvaluableNotFound, err)
 	})
 
 	t.Run("neq", func(t *testing.T) {
@@ -912,7 +907,6 @@ func TestAddRemove(t *testing.T) {
 			assert.Equal(t, 0, e.FastLen())
 		}, 300*time.Millisecond, 10*time.Millisecond)
 
-		// NOTE: With async GC, Remove() no longer returns an error for non-existent items
 	})
 
 	t.Run("Partial aggregates", func(t *testing.T) {