Skip to content

Static display & horizontal against 2.0 [odessyscience version]#9

Open
catskul wants to merge 6 commits into
insin:masterfrom
HireAnEsquire:static-display
Open

Static display & horizontal against 2.0 [odessyscience version]#9
catskul wants to merge 6 commits into
insin:masterfrom
HireAnEsquire:static-display

Conversation

@catskul

@catskul catskul commented Sep 26, 2015

Copy link
Copy Markdown

I took odessyscience's branch and rebased it on 2.0 and fixed one noticed problem.

@catskul

catskul commented Sep 30, 2015

Copy link
Copy Markdown
Author

Rendered difference:
screenshot from 2015-09-29 23 50 02

@catskul

catskul commented Sep 30, 2015

Copy link
Copy Markdown
Author

@seanadkinson any idea why this test might fail/ render the test seen above differently?

@seanadkinson

Copy link
Copy Markdown

Hadn't looked at the tests, but it seems like it is rendering extra empty divs.

How did you see the rendered difference? I just see the console output when running npm test.

Might be informative to have bootstrap.css loaded in the rendering, to see if it actually looks correct or not.

@catskul

catskul commented Sep 30, 2015

Copy link
Copy Markdown
Author

@seanadkinson I just put both into an empty html document to check the rendering to see if they were functionally equivalent. I'll try again with bootstrap.css loaded.

@catskul

catskul commented Sep 30, 2015

Copy link
Copy Markdown
Author

With bootstrap loaded they do look equivalent. So I think I can probably change the test to make it pass.

screenshot from 2015-09-30 12 17 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants