Commit feef4dd
committed
🐛 Fix fallback implementation of
Problem:
- The fallback implementation of `bit_ceil` is implemented incorrectly. In
particular it returns the wrong values for exact powers of 2.
Solution:
- Fix the calculation: subtracting 1 before calculating the bit width is
appropriate.
Notes:
- Thanks to Walter Brown for pointing out this issue in private correspondence.
- Undoubtedly, this was missed because of issue #117.bit_ceil
1 parent 0544692 commit feef4dd
2 files changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
| 226 | + | |
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
163 | 166 | | |
164 | 167 | | |
165 | 168 | | |
166 | 169 | | |
167 | 170 | | |
168 | 171 | | |
169 | 172 | | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
170 | 176 | | |
171 | 177 | | |
172 | 178 | | |
| |||
0 commit comments