Describe the bug
Currently we have 3 deprecated extensions that have been deprecated in favor of core spec / khr extensions.
We need to:
- deprecate the API (although I assume that it's deprecated already, but need to double-check and deprecate the leftover if any).
- guard all deprecated stuff with
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES to remove in the next ABI-break window.
- All 3 extensions specifications are duplicated - there is a file in
extensions/supported & extensions/deprecated. Usually we move specifications to the removed folder, but we can't do this until the API is removed. So I suggest to add a comment like this to the file in the supported dir:
// __INTEL_PREVIEW_BREAKING_CHANGES: remove this file along with the feature during the next ABI-break window.
and a comment like this to the file in the deprecated dir:
// __INTEL_PREVIEW_BREAKING_CHANGES: during the ABI-break window update the status of this specification according to https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/template.asciidoc and move it to the `removed` folder along with the removal of this feature.
Note - I suggest to remove each spec in a separate PR to avoid huge patches.
To reproduce
- Include a code snippet that is as short as possible
- Specify the command which should be used to compile the program
- Specify the command which should be used to launch the program
- Indicate what is wrong and what was expected
Environment
- OS: [e.g Windows/Linux]
- Target device and vendor: [e.g. Intel GPU]
- DPC++ version: [e.g. commit hash or output of
clang++ --version]
- Dependencies version: [e.g. the output of
sycl-ls --verbose]
Additional context
No response
Describe the bug
Currently we have 3 deprecated extensions that have been deprecated in favor of core spec / khr extensions.
We need to:
#ifndef __INTEL_PREVIEW_BREAKING_CHANGESto remove in the next ABI-break window.extensions/supported&extensions/deprecated. Usually we move specifications to theremovedfolder, but we can't do this until the API is removed. So I suggest to add a comment like this to the file in thesupporteddir:and a comment like this to the file in the
deprecateddir:Note - I suggest to remove each spec in a separate PR to avoid huge patches.
To reproduce
Environment
clang++ --version]sycl-ls --verbose]Additional context
No response