substituting /static/images for /images in all urls -fixes 12208

/images remains in the ngnix config, on the off chance that I missed a couple

Author: jack-wines

openlibrary/macros/CoverImage.html

@@ -34,4 +34,4 @@
     $if cover_url:
         <img src="$cover_url" height="58" title="$title" alt="$title"/>
     $else:
-        <img src="/images/icons/avatar_book-sm.png" alt="$title"/>
+        <img src="/static/images/icons/avatar_book-sm.png" alt="$title"/>

openlibrary/macros/FulltextSearchSuggestionItem.html

@@ -44,7 +44,7 @@
 <div class="fsi" itemscope itemtype="https://schema.org/Book" $:attrs>
   <div class="fsi__main">
     <span class="fsi__book-cover">
-      $ cover = get_cover_url(selected_ed) or "/images/icons/avatar_book-sm.png"
+      $ cover = get_cover_url(selected_ed) or "/static/images/icons/avatar_book-sm.png"
       <a data-ol-link-track="SearchInsideSuggestion|BookClick" href="$work_edition_url">
         <img class="fsi__book-cover-img $blur_cover"
               itemprop="image"

openlibrary/macros/LoadingIndicator.html

@@ -4,7 +4,7 @@
 
 <div class="$hidden loadingIndicator $additional_classes">
   <figure>
-  <img src="/images/ajax-loader-bar.gif" alt="$_('Loading indicator')" loading="lazy">
+  <img src="/static/images/ajax-loader-bar.gif" alt="$_('Loading indicator')" loading="lazy">
   <figcaption style="
       justify-content: center;
       display: flex;

openlibrary/macros/SearchResultsWork.html

@@ -64,7 +64,7 @@
     </div>
   <div class="sri__main">
     <span class="bookcover $blur_cover">
-      $ cover = get_cover_url(selected_ed) or "/images/icons/avatar_book-sm.png"
+      $ cover = get_cover_url(selected_ed) or "/static/images/icons/avatar_book-sm.png"
       <a href="$work_edition_url">
         <img
           itemprop="image"

openlibrary/plugins/openlibrary/js/covers.js

@@ -110,7 +110,7 @@ export function initCoversSaved() {
             cover_url = `${coverstore_url}/a/id/${image}-M.jpg`;
         }
         else {
-            cover_url = '/images/icons/avatar_author-lg.png';
+            cover_url = '/static/images/icons/avatar_author-lg.png';
         }
         parent.$(cover_selector).attr('src', cover_url);
     }

openlibrary/plugins/openlibrary/js/lists/ShowcaseItem.js

@@ -197,7 +197,7 @@ export class ShowcaseItem {
  */
 let i18nStrings
 
-const DEFAULT_COVER_URL = '/images/icons/avatar_book-sm.png'
+const DEFAULT_COVER_URL = '/static/images/icons/avatar_book-sm.png'
 
 /**
  * Returns the inferred type of the given seed key.

openlibrary/plugins/openlibrary/js/my-books/MyBooksDropper/ReadingLists.js

@@ -9,7 +9,7 @@ import { addItem, removeItem } from '../../lists/ListService'
 import { attachNewActiveShowcaseItem, toggleActiveShowcaseItems } from '../../lists/ShowcaseItem'
 import { FadingToast } from '../../Toast'
 
-const DEFAULT_COVER_URL = '/images/icons/avatar_book-sm.png'
+const DEFAULT_COVER_URL = '/static/images/icons/avatar_book-sm.png'
 
 /**
  * Represents a single My Books dropper's list affordances, and defines their

openlibrary/plugins/openlibrary/lists.py

@@ -240,9 +240,9 @@ def get_list_data(list, seed, include_cover_url=True):
     )
     if include_cover_url:
         cover = list.get_cover() or list.get_default_cover()
-        d["cover_url"] = (cover and cover.url("S")) or "/images/icons/avatar_book-sm.png"
+        d["cover_url"] = (cover and cover.url("S")) or "/static/images/icons/avatar_book-sm.png"
         if "None" in d["cover_url"]:
-            d["cover_url"] = "/images/icons/avatar_book-sm.png"
+            d["cover_url"] = "/static/images/icons/avatar_book-sm.png"
 
     d["owner"] = None
     if owner := list.get_owner():

openlibrary/plugins/upstream/addbook.py

@@ -82,7 +82,7 @@ def make_work(doc: dict[str, str | list]) -> web.Storage:
         for key, name in zip(doc.get('author_key', []), doc.get('author_name', []))
     ]
 
-    w.cover_url = "/images/icons/avatar_book-sm.png"
+    w.cover_url = "/static/images/icons/avatar_book-sm.png"
     w.setdefault('ia', [])
     w.setdefault('first_publish_year', None)
     return w

openlibrary/plugins/upstream/code.py

@@ -46,16 +46,6 @@
 
 logger = logging.getLogger('openlibrary.plugins.upstream.code')
 
-
-# Note: This is done in web_nginx.conf on production ; this endpoint is
-# only used in development environments.
-class static(delegate.page):
-    path = "/images/.*"
-
-    def GET(self):
-        return web.seeother(f'/static{web.ctx.path}')
-
-
 class history(delegate.mode):
     """Overwrite ?m=history to remove IP"""